element: remove unnecessary checks
authorPekka Pessi <Pekka.Pessi@nokia.com>
Fri, 10 Sep 2010 12:11:34 +0000 (15:11 +0300)
committerMarcel Holtmann <marcel@holtmann.org>
Mon, 13 Sep 2010 22:43:13 +0000 (07:43 +0900)
Do not check for null pointers after accessing data.

src/element.c

index 3309ae8..264b5a7 100644 (file)
@@ -1138,8 +1138,7 @@ static gboolean remove_element(GNode *node, gpointer user_data)
        if (element == root)
                return FALSE;
 
-       if (node != NULL)
-               g_node_unlink(node);
+       g_node_unlink(node);
 
        if (element->driver) {
                if (element->driver->remove)
@@ -1148,8 +1147,7 @@ static gboolean remove_element(GNode *node, gpointer user_data)
                element->driver = NULL;
        }
 
-       if (node != NULL)
-               g_node_destroy(node);
+       g_node_destroy(node);
 
        connman_element_unref(element);
 
@@ -1176,8 +1174,7 @@ static gboolean remove_element_type(GNode *node, gpointer user_data)
        if(element->type != type)
                return FALSE;
 
-       if (node != NULL)
-               g_node_unlink(node);
+       g_node_unlink(node);
 
        if (element->driver) {
                if (element->driver->remove)
@@ -1186,8 +1183,7 @@ static gboolean remove_element_type(GNode *node, gpointer user_data)
                element->driver = NULL;
        }
 
-       if (node != NULL)
-               g_node_destroy(node);
+       g_node_destroy(node);
 
        connman_element_unref(element);