ASoC: soc-component: add snd_soc_component_is_suspended()
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Fri, 26 Jul 2019 04:51:13 +0000 (13:51 +0900)
committerMark Brown <broonie@kernel.org>
Mon, 5 Aug 2019 15:21:17 +0000 (16:21 +0100)
Current ALSA SoC is directly using component->xxx,
But, it is not good for encapsulation.
This patch adds new snd_soc_component_is_suspended() and use it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/874l395rlx.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
include/sound/soc-component.h
sound/soc/soc-component.c
sound/soc/soc-core.c

index 1e3b708..9600dc4 100644 (file)
@@ -355,5 +355,6 @@ int snd_soc_component_trigger(struct snd_soc_component *component,
                              int cmd);
 void snd_soc_component_suspend(struct snd_soc_component *component);
 void snd_soc_component_resume(struct snd_soc_component *component);
+int snd_soc_component_is_suspended(struct snd_soc_component *component);
 
 #endif /* __SOC_COMPONENT_H */
index cbae767..0a9ca84 100644 (file)
@@ -361,3 +361,8 @@ void snd_soc_component_resume(struct snd_soc_component *component)
                component->driver->resume(component);
        component->suspended = 0;
 }
+
+int snd_soc_component_is_suspended(struct snd_soc_component *component)
+{
+       return component->suspended;
+}
index 6cdfe7b..ea93edd 100644 (file)
@@ -503,7 +503,7 @@ int snd_soc_suspend(struct device *dev)
                 * If there are paths active then the COMPONENT will be held
                 * with bias _ON and should not be suspended.
                 */
-               if (!component->suspended) {
+               if (!snd_soc_component_is_suspended(component)) {
                        switch (snd_soc_dapm_get_bias_level(dapm)) {
                        case SND_SOC_BIAS_STANDBY:
                                /*
@@ -592,9 +592,8 @@ static void soc_resume_deferred(struct work_struct *work)
        }
 
        for_each_card_components(card, component) {
-               if (component->suspended) {
+               if (snd_soc_component_is_suspended(component))
                        snd_soc_component_resume(component);
-               }
        }
 
        for_each_card_rtds(card, rtd) {