drm/amd/display: Fix memleak on input transfer function
authorLeo (Sunpeng) Li <sunpeng.li@amd.com>
Wed, 4 Apr 2018 20:01:30 +0000 (16:01 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 15 May 2018 18:43:02 +0000 (13:43 -0500)
Input transfer function creation is now done when the plane is created.
This is done within the following change:

    Author: Anthony Koo <Anthony.Koo@amd.com>
        drm/amd/display: Have DC manage its own allocation of gamma

Therefore, we no longer need to create it when filling in the plane
attributes.

Signed-off-by: Leo (Sunpeng) Li <sunpeng.li@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

index 18f221b..265f016 100644 (file)
@@ -2011,7 +2011,6 @@ static int fill_plane_attributes(struct amdgpu_device *adev,
        const struct amdgpu_framebuffer *amdgpu_fb =
                to_amdgpu_framebuffer(plane_state->fb);
        const struct drm_crtc *crtc = plane_state->crtc;
-       struct dc_transfer_func *input_tf;
        int ret = 0;
 
        if (!fill_rects_from_plane_state(plane_state, dc_plane_state))
@@ -2025,13 +2024,6 @@ static int fill_plane_attributes(struct amdgpu_device *adev,
        if (ret)
                return ret;
 
-       input_tf = dc_create_transfer_func();
-
-       if (input_tf == NULL)
-               return -ENOMEM;
-
-       dc_plane_state->in_transfer_func = input_tf;
-
        /*
         * Always set input transfer function, since plane state is refreshed
         * every time.