staging: r8188eu: remove unused field pdata
authorAbdun Nihaal <abdun.nihaal@gmail.com>
Thu, 3 Mar 2022 15:51:09 +0000 (21:21 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 14 Mar 2022 17:29:13 +0000 (18:29 +0100)
The field pdata in struct recv_buf is set but not used.
Remove it.

Also remove rtl8188eu_init_recvbuf function as it does nothing now.

Signed-off-by: Abdun Nihaal <abdun.nihaal@gmail.com>
Link: https://lore.kernel.org/r/7fe9ed2c6eade65c118511228283ef9d92ea4b43.1646321515.git.abdun.nihaal@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/hal/rtl8188eu_recv.c
drivers/staging/r8188eu/hal/usb_ops_linux.c
drivers/staging/r8188eu/include/rtl8188e_recv.h
drivers/staging/r8188eu/include/rtw_recv.h
drivers/staging/r8188eu/os_dep/recv_linux.c

index 9f772fc..2960e34 100644 (file)
 
 #include "../include/rtl8188e_hal.h"
 
-void rtl8188eu_init_recvbuf(struct recv_buf *precvbuf)
-{
-       if (precvbuf->pbuf) {
-               precvbuf->pdata = precvbuf->pbuf;
-       }
-}
-
 int    rtl8188eu_init_recv_priv(struct adapter *padapter)
 {
        struct recv_priv        *precvpriv = &padapter->recvpriv;
index f16a6bb..063bec9 100644 (file)
@@ -428,8 +428,6 @@ u32 rtw_read_port(struct adapter *adapter, u8 *rmem)
                        precvbuf->reuse = true;
        }
 
-       rtl8188eu_init_recvbuf(precvbuf);
-
        /* re-assign for linux based on skb */
        if (!precvbuf->reuse || !precvbuf->pskb) {
                precvbuf->pskb = netdev_alloc_skb(adapter->pnetdev, MAX_RECVBUF_SZ + RECVBUFF_ALIGN_SZ);
@@ -440,10 +438,8 @@ u32 rtw_read_port(struct adapter *adapter, u8 *rmem)
                alignment = tmpaddr & (RECVBUFF_ALIGN_SZ - 1);
                skb_reserve(precvbuf->pskb, (RECVBUFF_ALIGN_SZ - alignment));
 
-               precvbuf->pdata = precvbuf->pskb->data;
                precvbuf->pbuf = precvbuf->pskb->data;
        } else { /* reuse skb */
-               precvbuf->pdata = precvbuf->pskb->data;
                precvbuf->pbuf = precvbuf->pskb->data;
 
                precvbuf->reuse = false;
index 87dd415..a2320af 100644 (file)
@@ -37,7 +37,6 @@ enum rx_packet_type {
        HIS_REPORT,/*  USB HISR RPT */
 };
 
-void rtl8188eu_init_recvbuf(struct recv_buf *buf);
 s32 rtl8188eu_init_recv_priv(struct adapter *padapter);
 void rtl8188eu_free_recv_priv(struct adapter * padapter);
 void rtl8188eu_recv_hdl(struct adapter * padapter, struct recv_buf *precvbuf);
index f7bc1c9..55b1bb7 100644 (file)
@@ -210,7 +210,6 @@ struct recv_buf {
        struct adapter *adapter;
        u8      *pbuf;
        u8      *pallocated_buf;
-       u8      *pdata;
        struct urb *purb;
        dma_addr_t dma_transfer_addr;   /* (in) dma addr for transfer_buffer */
        u32 alloc_sz;
index c8a0ac8..a35c78f 100644 (file)
@@ -26,7 +26,6 @@ int rtw_os_recvbuf_resource_alloc(struct adapter *padapter,
        precvbuf->reuse = false;
        precvbuf->pallocated_buf = NULL;
        precvbuf->pbuf = NULL;
-       precvbuf->pdata = NULL;
        return res;
 }