efl_ui_dnd: cleanup when backend failed to create dnd op
authorMarcel Hollerbach <mail@marcel-hollerbach.de>
Mon, 6 Apr 2020 10:37:40 +0000 (12:37 +0200)
committerJongmin Lee <jm105.lee@samsung.com>
Tue, 7 Apr 2020 21:07:31 +0000 (06:07 +0900)
this is needed to not have a dead window on the screen.

Differential Revision: https://phab.enlightenment.org/D11654

src/lib/elementary/efl_ui_dnd.c

index 2774d24..7a765cd 100644 (file)
@@ -49,11 +49,17 @@ _efl_ui_dnd_drag_start(Eo *obj, Efl_Ui_Dnd_Data *pd, Eina_Content *content, cons
    elm_win_borderless_set(drag_win, EINA_TRUE);
    drag_ee = ecore_evas_ecore_evas_get(evas_object_evas_get(drag_win));
 
-   ecore_evas_drag_start(pd->ee, seat, content, drag_ee, action, _ecore_evas_drag_terminated, start);
-
-   evas_object_show(drag_win);
-
-   efl_event_callback_call(obj, EFL_UI_DND_EVENT_DRAG_STARTED, &ev);
+   if (!ecore_evas_drag_start(pd->ee, seat, content, drag_ee, action, _ecore_evas_drag_terminated, start))
+     {
+        efl_del(drag_win);
+        free(start);
+        drag_win = NULL;
+     }
+   else
+     {
+        evas_object_show(drag_win);
+        efl_event_callback_call(obj, EFL_UI_DND_EVENT_DRAG_STARTED, &ev);
+     }
 
    return drag_win;
 }