perf test: Pass the verbose option to shell tests
authorIan Rogers <irogers@google.com>
Mon, 21 Jun 2021 21:56:46 +0000 (14:56 -0700)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 22 Jun 2021 17:52:09 +0000 (14:52 -0300)
Having a verbose option will allow shell tests to provide extra failure
details when the fail or skip.

Committer notes:

Keep the 'script' variable at PATH_MAX, as its just something we'll pass
to system(), not really a "path", so being arbitrary, reduce the patch
size by not adding the three extra bytes to the 'script' variable.

Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Song Liu <songliubraving@fb.com>
Cc: bpf@vger.kernel.org
Link: http://lore.kernel.org/lkml/20210621215648.2991319-1-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/tests/builtin-test.c

index cbbfe48..41e3cf6 100644 (file)
@@ -580,7 +580,10 @@ static int shell_test__run(struct test *test, int subdir __maybe_unused)
        char script[PATH_MAX];
        struct shell_test *st = test->priv;
 
-       path__join(script, sizeof(script), st->dir, st->file);
+       path__join(script, sizeof(script) - 3, st->dir, st->file);
+
+       if (verbose)
+               strncat(script, " -v", sizeof(script) - strlen(script) - 1);
 
        err = system(script);
        if (!err)