Use parentheses around an argument to make these cause an error if you

	* garray.h (g_array_append_val, g_array_prepend_val,
	g_array_insert_val): Use parentheses around an argument to make
	these cause an error if you pass a non-lvalue for the value,
	rather than silently doing the wrong thing.

diff --git a/ChangeLog b/ChangeLog
index 582d21d..0fb9444 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2001-01-02  Dan Winship  <danw@helixcode.com>
+
+       * garray.h (g_array_append_val, g_array_prepend_val,
+       g_array_insert_val): Use parentheses around an argument to make
+       these cause an error if you pass a non-lvalue for the value,
+       rather than silently doing the wrong thing.
+
 2000-12-29  Tor Lillqvist  <tml@iki.fi>
 
        * glibconfig.h.win32.in: Add GLIB_SIZEOF_VOID_P and GLIB_SIZEOF_LONG.

diff --git a/ChangeLog.pre-2-0 b/ChangeLog.pre-2-0
index 582d21d..0fb9444 100644 (file)
--- a/ChangeLog.pre-2-0
+++ b/ChangeLog.pre-2-0
@@ -1,3 +1,10 @@
+2001-01-02  Dan Winship  <danw@helixcode.com>
+
+       * garray.h (g_array_append_val, g_array_prepend_val,
+       g_array_insert_val): Use parentheses around an argument to make
+       these cause an error if you pass a non-lvalue for the value,
+       rather than silently doing the wrong thing.
+
 2000-12-29  Tor Lillqvist  <tml@iki.fi>
 
        * glibconfig.h.win32.in: Add GLIB_SIZEOF_VOID_P and GLIB_SIZEOF_LONG.

diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index 582d21d..0fb9444 100644 (file)
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,3 +1,10 @@
+2001-01-02  Dan Winship  <danw@helixcode.com>
+
+       * garray.h (g_array_append_val, g_array_prepend_val,
+       g_array_insert_val): Use parentheses around an argument to make
+       these cause an error if you pass a non-lvalue for the value,
+       rather than silently doing the wrong thing.
+
 2000-12-29  Tor Lillqvist  <tml@iki.fi>
 
        * glibconfig.h.win32.in: Add GLIB_SIZEOF_VOID_P and GLIB_SIZEOF_LONG.

diff --git a/ChangeLog.pre-2-12 b/ChangeLog.pre-2-12
index 582d21d..0fb9444 100644 (file)
--- a/ChangeLog.pre-2-12
+++ b/ChangeLog.pre-2-12
@@ -1,3 +1,10 @@
+2001-01-02  Dan Winship  <danw@helixcode.com>
+
+       * garray.h (g_array_append_val, g_array_prepend_val,
+       g_array_insert_val): Use parentheses around an argument to make
+       these cause an error if you pass a non-lvalue for the value,
+       rather than silently doing the wrong thing.
+
 2000-12-29  Tor Lillqvist  <tml@iki.fi>
 
        * glibconfig.h.win32.in: Add GLIB_SIZEOF_VOID_P and GLIB_SIZEOF_LONG.

diff --git a/ChangeLog.pre-2-2 b/ChangeLog.pre-2-2
index 582d21d..0fb9444 100644 (file)
--- a/ChangeLog.pre-2-2
+++ b/ChangeLog.pre-2-2
@@ -1,3 +1,10 @@
+2001-01-02  Dan Winship  <danw@helixcode.com>
+
+       * garray.h (g_array_append_val, g_array_prepend_val,
+       g_array_insert_val): Use parentheses around an argument to make
+       these cause an error if you pass a non-lvalue for the value,
+       rather than silently doing the wrong thing.
+
 2000-12-29  Tor Lillqvist  <tml@iki.fi>
 
        * glibconfig.h.win32.in: Add GLIB_SIZEOF_VOID_P and GLIB_SIZEOF_LONG.

diff --git a/ChangeLog.pre-2-4 b/ChangeLog.pre-2-4
index 582d21d..0fb9444 100644 (file)
--- a/ChangeLog.pre-2-4
+++ b/ChangeLog.pre-2-4
@@ -1,3 +1,10 @@
+2001-01-02  Dan Winship  <danw@helixcode.com>
+
+       * garray.h (g_array_append_val, g_array_prepend_val,
+       g_array_insert_val): Use parentheses around an argument to make
+       these cause an error if you pass a non-lvalue for the value,
+       rather than silently doing the wrong thing.
+
 2000-12-29  Tor Lillqvist  <tml@iki.fi>
 
        * glibconfig.h.win32.in: Add GLIB_SIZEOF_VOID_P and GLIB_SIZEOF_LONG.

diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6
index 582d21d..0fb9444 100644 (file)
--- a/ChangeLog.pre-2-6
+++ b/ChangeLog.pre-2-6
@@ -1,3 +1,10 @@
+2001-01-02  Dan Winship  <danw@helixcode.com>
+
+       * garray.h (g_array_append_val, g_array_prepend_val,
+       g_array_insert_val): Use parentheses around an argument to make
+       these cause an error if you pass a non-lvalue for the value,
+       rather than silently doing the wrong thing.
+
 2000-12-29  Tor Lillqvist  <tml@iki.fi>
 
        * glibconfig.h.win32.in: Add GLIB_SIZEOF_VOID_P and GLIB_SIZEOF_LONG.

diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8
index 582d21d..0fb9444 100644 (file)
--- a/ChangeLog.pre-2-8
+++ b/ChangeLog.pre-2-8
@@ -1,3 +1,10 @@
+2001-01-02  Dan Winship  <danw@helixcode.com>
+
+       * garray.h (g_array_append_val, g_array_prepend_val,
+       g_array_insert_val): Use parentheses around an argument to make
+       these cause an error if you pass a non-lvalue for the value,
+       rather than silently doing the wrong thing.
+
 2000-12-29  Tor Lillqvist  <tml@iki.fi>
 
        * glibconfig.h.win32.in: Add GLIB_SIZEOF_VOID_P and GLIB_SIZEOF_LONG.

diff --git a/garray.h b/garray.h
index 4359c88..ddade36 100644 (file)
--- a/garray.h
+++ b/garray.h
@@ -58,9 +58,9 @@ struct _GPtrArray
  * order by moving the last element to the position of the removed 
  */
 
-#define g_array_append_val(a,v)          g_array_append_vals (a, &v, 1)
-#define g_array_prepend_val(a,v)  g_array_prepend_vals (a, &v, 1)
-#define g_array_insert_val(a,i,v) g_array_insert_vals (a, i, &v, 1)
+#define g_array_append_val(a,v)          g_array_append_vals (a, &(v), 1)
+#define g_array_prepend_val(a,v)  g_array_prepend_vals (a, &(v), 1)
+#define g_array_insert_val(a,i,v) g_array_insert_vals (a, i, &(v), 1)
 #define g_array_index(a,t,i)      (((t*) (a)->data) [(i)])
 
 GArray* g_array_new               (gboolean          zero_terminated,

diff --git a/glib/garray.h b/glib/garray.h
index 4359c88..ddade36 100644 (file)
--- a/glib/garray.h
+++ b/glib/garray.h
@@ -58,9 +58,9 @@ struct _GPtrArray
  * order by moving the last element to the position of the removed 
  */
 
-#define g_array_append_val(a,v)          g_array_append_vals (a, &v, 1)
-#define g_array_prepend_val(a,v)  g_array_prepend_vals (a, &v, 1)
-#define g_array_insert_val(a,i,v) g_array_insert_vals (a, i, &v, 1)
+#define g_array_append_val(a,v)          g_array_append_vals (a, &(v), 1)
+#define g_array_prepend_val(a,v)  g_array_prepend_vals (a, &(v), 1)
+#define g_array_insert_val(a,i,v) g_array_insert_vals (a, i, &(v), 1)
 #define g_array_index(a,t,i)      (((t*) (a)->data) [(i)])
 
 GArray* g_array_new               (gboolean          zero_terminated,