staging: rtl8192e: Rename sCrcLng
authorPhilipp Hortmann <philipp.g.hortmann@gmail.com>
Sun, 29 Jan 2023 14:58:07 +0000 (15:58 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 31 Jan 2023 10:16:33 +0000 (11:16 +0100)
Rename constant sCrcLng to S_CRC_LEN to avoid CamelCase which is not
accepted by checkpatch. Use S_CRC_LEN instead of fix value with comment
to improve readability.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/b0139a958123881fd04b60110a6889f726d943cc.1675003608.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
drivers/staging/rtl8192e/rtl8192e/rtl_core.c
drivers/staging/rtl8192e/rtl8192e/rtl_core.h

index 7ed3d47..912b50d 100644 (file)
@@ -1827,7 +1827,7 @@ bool rtl92e_get_rx_stats(struct net_device *dev, struct rtllib_rx_stats *stats,
        stats->RxIs40MHzPacket = pDrvInfo->BW;
 
        _rtl92e_translate_rx_signal_stats(dev, skb, stats, pdesc, pDrvInfo);
-       skb_trim(skb, skb->len - 4/*sCrcLng*/);
+       skb_trim(skb, skb->len - S_CRC_LEN);
 
 
        stats->packetlength = stats->Length-4;
index f8a8ece..26cf4b5 100644 (file)
@@ -1906,7 +1906,7 @@ static void _rtl92e_rx_normal(struct net_device *dev)
                skb_put(skb, pdesc->Length);
                skb_reserve(skb, stats.RxDrvInfoSize +
                        stats.RxBufShift);
-               skb_trim(skb, skb->len - 4/*sCrcLng*/);
+               skb_trim(skb, skb->len - S_CRC_LEN);
                rtllib_hdr = (struct rtllib_hdr_1addr *)skb->data;
                if (!is_multicast_ether_addr(rtllib_hdr->addr1)) {
                        /* unicast packet */
index 1287580..a5812df 100644 (file)
@@ -94,7 +94,7 @@
 #define CCK_TX_BB_GAIN_TABLE_LEN               23
 
 #define CHANNEL_PLAN_LEN                       10
-#define sCrcLng                                        4
+#define S_CRC_LEN                              4
 
 #define NIC_SEND_HANG_THRESHOLD_NORMAL         4
 #define NIC_SEND_HANG_THRESHOLD_POWERSAVE      8