media: i2c: ov7251: Add fwnode properties controls
authorDave Stevenson <dave.stevenson@raspberrypi.com>
Tue, 3 Aug 2021 10:33:33 +0000 (11:33 +0100)
committerDom Cobley <popcornmix@gmail.com>
Mon, 19 Feb 2024 11:33:11 +0000 (11:33 +0000)
Add call to v4l2_ctrl_new_fwnode_properties to read and
create the fwnode based controls.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
drivers/media/i2c/ov7251.c

index 675fb37..0730bfc 100644 (file)
@@ -1541,7 +1541,7 @@ static int ov7251_init_ctrls(struct ov7251 *ov7251)
        s64 pixel_rate;
        int hblank;
 
-       v4l2_ctrl_handler_init(&ov7251->ctrls, 7);
+       v4l2_ctrl_handler_init(&ov7251->ctrls, 9);
        ov7251->ctrls.lock = &ov7251->lock;
 
        v4l2_ctrl_new_std(&ov7251->ctrls, &ov7251_ctrl_ops,
@@ -1600,6 +1600,7 @@ static int ov7251_init_ctrls(struct ov7251 *ov7251)
 
 static int ov7251_probe(struct i2c_client *client)
 {
+       struct v4l2_fwnode_device_properties props;
        struct device *dev = &client->dev;
        struct ov7251 *ov7251;
        unsigned int rate = 0, clk_rate = 0;
@@ -1690,6 +1691,15 @@ static int ov7251_probe(struct i2c_client *client)
                goto destroy_mutex;
        }
 
+       ret = v4l2_fwnode_device_parse(&client->dev, &props);
+       if (ret)
+               goto free_ctrl;
+
+       ret = v4l2_ctrl_new_fwnode_properties(&ov7251->ctrls, &ov7251_ctrl_ops,
+                                             &props);
+       if (ret)
+               goto free_ctrl;
+
        v4l2_i2c_subdev_init(&ov7251->sd, client, &ov7251_subdev_ops);
        ov7251->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
        ov7251->pad.flags = MEDIA_PAD_FL_SOURCE;