drm/msm: use BUG_ON macro for debugging.
authorWambui Karuga <wambui.karugax@gmail.com>
Mon, 30 Dec 2019 19:41:02 +0000 (22:41 +0300)
committerRob Clark <robdclark@chromium.org>
Fri, 3 Jan 2020 00:17:20 +0000 (16:17 -0800)
As the if statement only checks for the value of the offset_name
variable, it can be replaced by the more conscise BUG_ON macro for error
reporting.

Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
Reviewed-by: Sean Paul <sean@poorly.run>
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/adreno/adreno_gpu.h

index cd7ec02..9ff4e55 100644 (file)
@@ -340,10 +340,7 @@ OUT_PKT7(struct msm_ringbuffer *ring, uint8_t opcode, uint16_t cnt)
 static inline bool adreno_reg_check(struct adreno_gpu *gpu,
                enum adreno_regs offset_name)
 {
-       if (offset_name >= REG_ADRENO_REGISTER_MAX ||
-                       !gpu->reg_offsets[offset_name]) {
-               BUG();
-       }
+       BUG_ON(offset_name >= REG_ADRENO_REGISTER_MAX || !gpu->reg_offsets[offset_name]);
 
        /*
         * REG_SKIP is a special value that tell us that the register in