ALSA: hda: cs35l41: Improve dev_err_probe() messaging

Drop duplicate print of returned value in the messages and use pattern
return dev_err_probe(...) where it's possible.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20220711095219.36915-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c
index a9923a8..49b2543 100644 (file)
--- a/sound/pci/hda/cs35l41_hda.c
+++ b/sound/pci/hda/cs35l41_hda.c
@@ -460,10 +460,8 @@ int cs35l41_hda_probe(struct device *dev, const char *device_name, int id, int i
        dev_set_drvdata(dev, cs35l41);
 
        ret = cs35l41_hda_read_acpi(cs35l41, device_name, id);
-       if (ret) {
-               dev_err_probe(cs35l41->dev, ret, "Platform not supported %d\n", ret);
-               return ret;
-       }
+       if (ret)
+               return dev_err_probe(cs35l41->dev, ret, "Platform not supported\n");
 
        if (IS_ERR(cs35l41->reset_gpio)) {
                ret = PTR_ERR(cs35l41->reset_gpio);
@@ -471,7 +469,7 @@ int cs35l41_hda_probe(struct device *dev, const char *device_name, int id, int i
                if (ret == -EBUSY) {
                        dev_info(cs35l41->dev, "Reset line busy, assuming shared reset\n");
                } else {
-                       dev_err_probe(cs35l41->dev, ret, "Failed to get reset GPIO: %d\n", ret);
+                       dev_err_probe(cs35l41->dev, ret, "Failed to get reset GPIO\n");
                        goto err;
                }
        }