team: Remove dead code
authorKenneth Williams <ken@williamsclan.us>
Mon, 12 Jan 2015 00:43:54 +0000 (16:43 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 12 Jan 2015 22:02:04 +0000 (17:02 -0500)
The deleted lines are called from a function which is called:
1) Only through __team_options_register via team_options_register and
2) Only during initialization / mode initialization when there are no
ports attached.
Therefore the ports list is guarenteed to be empty and this code will
never be executed.

Signed-off-by: Kenneth Williams <ken@williamsclan.us>
Acked-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/team/team.c

index 93e2242..43bcfff 100644 (file)
@@ -176,7 +176,6 @@ static int __team_option_inst_add(struct team *team, struct team_option *option,
 static int __team_option_inst_add_option(struct team *team,
                                         struct team_option *option)
 {
-       struct team_port *port;
        int err;
 
        if (!option->per_port) {
@@ -184,12 +183,6 @@ static int __team_option_inst_add_option(struct team *team,
                if (err)
                        goto inst_del_option;
        }
-
-       list_for_each_entry(port, &team->port_list, list) {
-               err = __team_option_inst_add(team, option, port);
-               if (err)
-                       goto inst_del_option;
-       }
        return 0;
 
 inst_del_option: