erofs: get rid of debug_one_dentry()
authorGao Xiang <hsiangkao@linux.alibaba.com>
Sat, 14 Jan 2023 12:57:45 +0000 (20:57 +0800)
committerGao Xiang <hsiangkao@linux.alibaba.com>
Wed, 15 Feb 2023 00:11:23 +0000 (08:11 +0800)
Since erofsdump is available, no need to keep this debugging
functionality at all.

Also drop a useless comment since it's the VFS behavior.

Link: https://lore.kernel.org/r/20230114125746.399253-1-xiang@kernel.org
Reviewed-by: Yue Hu <huyue2@coolpad.com>
Reviewed-by: Jingbo Xu <jefflexu@linux.alibaba.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
fs/erofs/dir.c

index ecf28f6..6970b09 100644 (file)
@@ -6,21 +6,6 @@
  */
 #include "internal.h"
 
-static void debug_one_dentry(unsigned char d_type, const char *de_name,
-                            unsigned int de_namelen)
-{
-#ifdef CONFIG_EROFS_FS_DEBUG
-       /* since the on-disk name could not have the trailing '\0' */
-       unsigned char dbg_namebuf[EROFS_NAME_LEN + 1];
-
-       memcpy(dbg_namebuf, de_name, de_namelen);
-       dbg_namebuf[de_namelen] = '\0';
-
-       erofs_dbg("found dirent %s de_len %u d_type %d", dbg_namebuf,
-                 de_namelen, d_type);
-#endif
-}
-
 static int erofs_fill_dentries(struct inode *dir, struct dir_context *ctx,
                               void *dentry_blk, struct erofs_dirent *de,
                               unsigned int nameoff, unsigned int maxsize)
@@ -52,10 +37,8 @@ static int erofs_fill_dentries(struct inode *dir, struct dir_context *ctx,
                        return -EFSCORRUPTED;
                }
 
-               debug_one_dentry(d_type, de_name, de_namelen);
                if (!dir_emit(ctx, de_name, de_namelen,
                              le64_to_cpu(de->nid), d_type))
-                       /* stopped by some reason */
                        return 1;
                ++de;
                ctx->pos += sizeof(struct erofs_dirent);