amba: bus: fix refcount leak
authorPeng Fan <peng.fan@nxp.com>
Mon, 21 Aug 2023 02:39:27 +0000 (10:39 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 22 Aug 2023 13:50:57 +0000 (15:50 +0200)
commit 5de1540b7bc4 ("drivers/amba: create devices from device tree")
increases the refcount of of_node, but not releases it in
amba_device_release, so there is refcount leak. By using of_node_put
to avoid refcount leak.

Fixes: 5de1540b7bc4 ("drivers/amba: create devices from device tree")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230821023928.3324283-1-peng.fan@oss.nxp.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/amba/bus.c

index ce88af9..09e7296 100644 (file)
@@ -528,6 +528,7 @@ static void amba_device_release(struct device *dev)
 {
        struct amba_device *d = to_amba_device(dev);
 
+       of_node_put(d->dev.of_node);
        if (d->res.parent)
                release_resource(&d->res);
        mutex_destroy(&d->periphid_lock);