kate: fix implicit promotion to signed int breaking on largeish inputs
authorVincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Wed, 9 Apr 2014 17:31:31 +0000 (18:31 +0100)
committerVincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Wed, 9 Apr 2014 17:31:31 +0000 (18:31 +0100)
Coverity 1139858, 1139857

ext/kate/gstkatespu.c

index 951ef0f..e256f86 100644 (file)
@@ -601,8 +601,8 @@ gst_kate_spu_decode_spu (GstKateEnc * ke, GstBuffer * buf, kate_region * kr,
     /* prefer relative sizes in case we're encoding for a different resolution
        that what the SPU was created for */
     kr->metric = kate_millionths;
-    kr->x = 1000000 * x / ke->original_canvas_width;
-    kr->y = 1000000 * y / ke->original_canvas_height;
+    kr->x = 1000000 * (size_t) x / ke->original_canvas_width;
+    kr->y = 1000000 * (size_t) y / ke->original_canvas_height;
     kr->w = 1000000 * kb->width / ke->original_canvas_width;
     kr->h = 1000000 * kb->height / ke->original_canvas_height;
   } else {