[es6] Move builtin constructors for primitives to strict mode.

The ES6 specification says that "Built-in functions that are ECMAScript
function objects must be strict mode functions", which in particular
means that you can never test for them using the "caller" field of a
sloppy mode function.

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_layout_dbg,v8_linux_nosnap_dbg
R=mstarzinger@chromium.org
BUG=v8:105
LOG=n

Review URL: https://codereview.chromium.org/1347663002

Cr-Commit-Position: refs/heads/master@{#30750}

diff --git a/src/string.js b/src/string.js
index a8a9e8bd3af67f0878f4a8b34ce9c8cf49793c6d..e6671eec17d991ce8d4a5ae9a8e800bd76f8ead6 100644 (file)
--- a/src/string.js
+++ b/src/string.js
@@ -36,6 +36,8 @@ utils.Import(function(from) {
 //-------------------------------------------------------------------
 
 function StringConstructor(x) {
+  // TODO(bmeurer): Move this to toplevel.
+  "use strict";
   if (%_ArgumentsLength() == 0) x = '';
   if (%_IsConstructCall()) {
     %_SetValueOf(this, TO_STRING_INLINE(x));

diff --git a/src/v8natives.js b/src/v8natives.js
index a9306003b84c4aba7cb8149e49d0325153ace9a0..6106ae9146316b627cbc5f28f7a2cb561110e355 100644 (file)
--- a/src/v8natives.js
+++ b/src/v8natives.js
@@ -1341,6 +1341,8 @@ utils.InstallFunctions(GlobalObject, DONT_ENUM, [
 // Boolean
 
 function BooleanConstructor(x) {
+  // TODO(bmeurer): Move this to toplevel.
+  "use strict";
   if (%_IsConstructCall()) {
     %_SetValueOf(this, ToBoolean(x));
   } else {
@@ -1390,6 +1392,8 @@ utils.InstallFunctions(GlobalBoolean.prototype, DONT_ENUM, [
 // Number
 
 function NumberConstructor(x) {
+  // TODO(bmeurer): Move this to toplevel.
+  "use strict";
   var value = %_ArgumentsLength() == 0 ? 0 : ToNumber(x);
   if (%_IsConstructCall()) {
     %_SetValueOf(this, value);

diff --git a/test/mjsunit/regress/regress-105.js b/test/mjsunit/regress/regress-105.js
index 8b8030ffec0288e6812ae3785f672a6b3beb6e48..877cb82317a4514b2abc23c844be648fa95812af 100644 (file)
--- a/test/mjsunit/regress/regress-105.js
+++ b/test/mjsunit/regress/regress-105.js
@@ -26,12 +26,12 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 var custom_valueOf = function() {
-  assertEquals(Number, custom_valueOf.caller);
+  assertEquals(null, custom_valueOf.caller);
   return 2;
 }
 
 var custom_toString = function() {
-  assertEquals(String, custom_toString.caller);
+  assertEquals(null, custom_toString.caller);
   return "I used to be an adventurer like you";
 }