power_supply: Make goldfish_battery depend on GOLDFISH || COMPILE_TEST
authorPaul Gortmaker <paul.gortmaker@windriver.com>
Thu, 4 Jul 2013 05:39:11 +0000 (01:39 -0400)
committerAnton Vorontsov <anton@enomsg.org>
Fri, 9 Aug 2013 20:28:47 +0000 (13:28 -0700)
Nearly all the other goldfish peripherals (mtd, keyboard, etc) have a
dependency on the main platform's GOLDFISH Kconfig item, but this one got
skipped.  Even with consistency as a justification, there was initial
resistance[1] from some people to adding it however, as they wanted the
extra compile coverage.

Now, with CONFIG_COMPILE_TEST, we have the middle ground that will give
people the coverage who want it, and let those who don't want it to skip
ever seeing the option presented.

[1] https://lkml.org/lkml/2013/2/27/333

Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Jiri Slaby <jslaby@suse.cz>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Anton Vorontsov <anton@enomsg.org>
drivers/power/Kconfig

index 7b8979c..dcc0d9e 100644 (file)
@@ -357,7 +357,7 @@ config AB8500_BM
 
 config BATTERY_GOLDFISH
        tristate "Goldfish battery driver"
-       depends on GENERIC_HARDIRQS
+       depends on GENERIC_HARDIRQS && (GOLDFISH || COMPILE_TEST)
        help
          Say Y to enable support for the battery and AC power in the
          Goldfish emulator.