[lldb] Re-add nullptr check to IRForTarget::RewriteObjCConstString log statement
authorRaphael Isemann <teemperor@gmail.com>
Mon, 16 Mar 2020 15:21:32 +0000 (16:21 +0100)
committerRaphael Isemann <teemperor@gmail.com>
Mon, 16 Mar 2020 15:28:36 +0000 (16:28 +0100)
The nullptr check here was removed in 4ef50a33b12825593a82ca8ea97158b7b71b348e
when I replaced (nearly) all log->Print to LLDB_LOG calls (which automatically
check for this stuff). But it seems this one call escaped my sed call.

Currently working on a test that can cover this code path but we can revert
this until I have found one.

lldb/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp

index e70ab1c..b944287 100644 (file)
@@ -427,7 +427,7 @@ bool IRForTarget::RewriteObjCConstString(llvm::GlobalVariable *ns_str,
         m_execution_unit.FindSymbol(g_CFStringCreateWithBytes_str, 
                                     missing_weak);
     if (CFStringCreateWithBytes_addr == LLDB_INVALID_ADDRESS || missing_weak) {
-        log->PutCString("Couldn't find CFStringCreateWithBytes in the target");
+      LLDB_LOG(log, "Couldn't find CFStringCreateWithBytes in the target");
 
       m_error_stream.Printf("Error [IRForTarget]: Rewriting an Objective-C "
                             "constant string requires "