projects
/
platform
/
upstream
/
glib.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
30772e7
)
GMemoryOutputStream: Don't return -1 as a gboolean in precondition
author
Colin Walters
<walters@verbum.org>
Tue, 8 Oct 2013 16:17:16 +0000
(12:17 -0400)
committer
Colin Walters
<walters@verbum.org>
Tue, 8 Oct 2013 16:19:11 +0000
(12:19 -0400)
Since it could confuse callers (admittedly who are already violating
a precondition).
Just spotted while adapting some bits of this code for a ssh library.
gio/gmemoryoutputstream.c
patch
|
blob
|
history
diff --git
a/gio/gmemoryoutputstream.c
b/gio/gmemoryoutputstream.c
index
d37b46e
..
82edceb
100644
(file)
--- a/
gio/gmemoryoutputstream.c
+++ b/
gio/gmemoryoutputstream.c
@@
-678,7
+678,7
@@
g_memory_output_stream_close_finish (GOutputStream *stream,
GAsyncResult *result,
GError **error)
{
- g_return_val_if_fail (g_task_is_valid (result, stream),
-1
);
+ g_return_val_if_fail (g_task_is_valid (result, stream),
FALSE
);
return g_task_propagate_boolean (G_TASK (result), error);
}