staging: r8188eu: _offset is always 0 in efuse_phymap_to_logical
authorMartin Kaiser <martin@kaiser.cx>
Sat, 9 Jul 2022 17:09:58 +0000 (19:09 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 11 Jul 2022 08:06:45 +0000 (10:06 +0200)
The _offset parameter of iol_read_efuse is always 0. Remove the
parameter and use 0 in the function body.

We can now replace the bytewise copy from efuseTbl to pbuf with memcpy.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20220709171000.180481-13-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/hal/rtl8188e_hal_init.c

index f552b9a..87ebfb0 100644 (file)
@@ -83,7 +83,7 @@ static s32 iol_InitLLTTable(struct adapter *padapter, u8 txpktbuf_bndy)
 }
 
 static void
-efuse_phymap_to_logical(u8 *phymap, u16 _offset, u16 _size_byte, u8  *pbuf)
+efuse_phymap_to_logical(u8 *phymap, u16 _size_byte, u8  *pbuf)
 {
        u8 *efuseTbl = NULL;
        u8 rtemp8;
@@ -188,8 +188,7 @@ efuse_phymap_to_logical(u8 *phymap, u16 _offset, u16 _size_byte, u8  *pbuf)
        /*  */
        /*  4. Copy from Efuse map to output pointer memory!!! */
        /*  */
-       for (i = 0; i < _size_byte; i++)
-               pbuf[i] = efuseTbl[_offset + i];
+       memcpy(pbuf, efuseTbl, _size_byte);
 
        /*  */
        /*  5. Calculate Efuse utilization. */
@@ -311,7 +310,7 @@ static s32 iol_read_efuse(struct adapter *padapter, u16 size_byte, u8 *logical_m
        status = iol_execute(padapter, CMD_READ_EFUSE_MAP);
        if (status == _SUCCESS)
                efuse_read_phymap_from_txpktbuf(padapter, 0, physical_map, &size);
-       efuse_phymap_to_logical(physical_map, 0, size_byte, logical_map);
+       efuse_phymap_to_logical(physical_map, size_byte, logical_map);
        return status;
 }