[clang-format] Handle "// clang-format off" for RemoveBracesLLVM
authorowenca <owenpiano@gmail.com>
Thu, 10 Mar 2022 04:38:43 +0000 (20:38 -0800)
committerowenca <owenpiano@gmail.com>
Thu, 10 Mar 2022 21:30:53 +0000 (13:30 -0800)
Differential Revision: https://reviews.llvm.org/D121352

clang/lib/Format/Format.cpp
clang/unittests/Format/FormatTest.cpp

index 6c2765c..a8b8efb 100644 (file)
@@ -1808,7 +1808,8 @@ private:
       removeBraces(Line->Children, Result);
       if (!Line->Affected)
         continue;
-      for (FormatToken *Token = Line->First; Token; Token = Token->Next) {
+      for (FormatToken *Token = Line->First; Token && !Token->Finalized;
+           Token = Token->Next) {
         if (!Token->Optional)
           continue;
         assert(Token->isOneOf(tok::l_brace, tok::r_brace));
index 1d9b158..dab8f83 100644 (file)
@@ -24805,6 +24805,19 @@ TEST_F(FormatTest, RemoveBraces) {
                "}",
                Style);
 
+  verifyFormat("// clang-format off\n"
+               "// comment\n"
+               "while (i > 0) { --i; }\n"
+               "// clang-format on\n"
+               "while (j < 0)\n"
+               "  ++j;",
+               "// clang-format off\n"
+               "// comment\n"
+               "while (i > 0) { --i; }\n"
+               "// clang-format on\n"
+               "while (j < 0) { ++j; }",
+               Style);
+
   verifyFormat("if (a)\n"
                "  b; // comment\n"
                "else if (c)\n"