watchdog: watchdog_dev: mark expected switch fall-through
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Fri, 3 Nov 2017 23:03:27 +0000 (18:03 -0500)
committerWim Van Sebroeck <wim@iguana.be>
Thu, 28 Dec 2017 19:45:30 +0000 (20:45 +0100)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Notice that in this particular case I replaced "Fall" with a proper
"fall through" comment, which is what GCC is expecting to find.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
drivers/watchdog/watchdog_dev.c

index 95b96f3..eb35700 100644 (file)
@@ -720,7 +720,7 @@ static long watchdog_ioctl(struct file *file, unsigned int cmd,
                err = watchdog_ping(wdd);
                if (err < 0)
                        break;
-               /* Fall */
+               /* fall through */
        case WDIOC_GETTIMEOUT:
                /* timeout == 0 means that we don't know the timeout */
                if (wdd->timeout == 0) {