Bug fix - invalid bitrate setting 47/315747/1 accepted/tizen/7.0/unified/20241205.085634
authorJeongmo Yang <jm80.yang@samsung.com>
Wed, 4 Dec 2024 10:08:50 +0000 (19:08 +0900)
committerJeongmo Yang <jm80.yang@samsung.com>
Wed, 4 Dec 2024 10:09:31 +0000 (19:09 +0900)
- Do not multiply 1000 with bitrate from media format.
  They are same unit.(bps)
- Remove bitrate setting when make packets for packet pool.

[Version] 0.6.37
[Issue Type] Bug fix

Change-Id: Ib6eea22ee25a46abed950cf7679361a0e277c41d
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
packaging/capi-media-codec.spec
src/media_codec_port_gst.c

index 9293d6543a8f9cc9f4339d32732ecfa46b965c82..1ba7e64c0ebc6dff52aa0378eb49d5a056b91a09 100644 (file)
@@ -4,7 +4,7 @@
 
 Name:       capi-media-codec
 Summary:    A Media Codec library in Tizen Native API
-Version:    0.6.36
+Version:    0.6.37
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0
index 25a987a2e700dd2bcb1138f361b254adc069db87..e3bfae279debc96b9e438d9f3400dc05df4603ee 100644 (file)
@@ -1115,7 +1115,6 @@ gboolean _mc_update_packet_info(mc_gst_core_t *core, media_format_h format)
                }
 
                if (core->encoder) {
-                       bitrate *= 1000;
                        sformat = __mc_get_gst_input_format(mimetype, core->is_hw);
                        is_format_change |= ((input_port_def->info.video.bitrate != bitrate) && (bitrate != 0));
                        is_format_change |= g_strcmp0(input_port_def->info.video.format, sformat);
@@ -1153,7 +1152,6 @@ gboolean _mc_update_packet_info(mc_gst_core_t *core, media_format_h format)
                }
 
                if (core->encoder) {
-                       bitrate *= 1000;
                        is_format_change |= ((input_port_def->info.audio.bitrate != bitrate) && (bitrate != 0));
                        if (is_format_change) {
                                LOGD("Bitrate changed : %d -> %d", input_port_def->info.audio.bitrate, bitrate);
@@ -3757,16 +3755,11 @@ mc_ret_e mc_gst_get_packet_pool(mc_handle_t *mc_handle, media_packet_pool_h *pac
                media_format_set_video_mime(fmt_handle, mime_format);
                media_format_set_video_width(fmt_handle, mc_handle->info.video.width);
                media_format_set_video_height(fmt_handle, mc_handle->info.video.height);
-
-               if (core->encoder)
-                       media_format_set_video_avg_bps(fmt_handle, mc_handle->info.video.bitrate);
        } else {
-                       media_format_set_audio_mime(fmt_handle, mime_format);
-                       media_format_set_audio_channel(fmt_handle, mc_handle->info.audio.channel);
-                       media_format_set_audio_samplerate(fmt_handle, mc_handle->info.audio.samplerate);
-                       media_format_set_audio_bit(fmt_handle, mc_handle->info.audio.bit_depth);
-               if (core->encoder)
-                       media_format_set_audio_avg_bps(fmt_handle, mc_handle->info.audio.bitrate);
+               media_format_set_audio_mime(fmt_handle, mime_format);
+               media_format_set_audio_channel(fmt_handle, mc_handle->info.audio.channel);
+               media_format_set_audio_samplerate(fmt_handle, mc_handle->info.audio.samplerate);
+               media_format_set_audio_bit(fmt_handle, mc_handle->info.audio.bit_depth);
        }
 
        ret = media_packet_pool_set_media_format(pool, fmt_handle);