macintosh/adb-iop: Implement sending -> idle state transition

On leaving the 'sending' state, proceed to the 'idle' state if no reply is
expected. Drop redundant test for adb_iop_state == sending && current_req.

Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/6991996dd4aaf0b52cfd650172bf0f6fbe37a452.1590880623.git.fthain@telegraphics.com.au

diff --git a/drivers/macintosh/adb-iop.c b/drivers/macintosh/adb-iop.c
index f22792c95d4fae1617ee34c0b5912cbfb8fb2b93..8594e4f9a830960b30902290a524421de28e49d9 100644 (file)
--- a/drivers/macintosh/adb-iop.c
+++ b/drivers/macintosh/adb-iop.c
@@ -77,15 +77,14 @@ static void adb_iop_done(void)
 
 static void adb_iop_complete(struct iop_msg *msg)
 {
-       struct adb_request *req;
        unsigned long flags;
 
        local_irq_save(flags);
 
-       req = current_req;
-       if ((adb_iop_state == sending) && req && req->reply_expected) {
+       if (current_req->reply_expected)
                adb_iop_state = awaiting_reply;
-       }
+       else
+               adb_iop_done();
 
        local_irq_restore(flags);
 }