Fix pylint warnings
authorSateesh Kumar <sateeshkumarb@yahoo.com>
Sat, 7 Dec 2013 16:55:53 +0000 (22:25 +0530)
committerSateesh Kumar <sateeshkumarb@yahoo.com>
Sat, 7 Dec 2013 16:55:53 +0000 (22:25 +0530)
jenkinsapi/jenkins.py
jenkinsapi_tests/unittests/test_jenkins.py

index c5f06ba..11c65d8 100644 (file)
@@ -318,14 +318,14 @@ class Jenkins(JenkinsBase):
     def get_executors(self, nodename):
         url = '%s/computer/%s' % (self.baseurl, nodename)
         return Executors(url, nodename, self)
-  
+
     def get_version(self):
         """
         Return version number of Jenkins
         """
-        r = self.requester.get_and_confirm_status(self.baseurl)
+        response = self.requester.get_and_confirm_status(self.baseurl)
         try:
-            return r.headers['X-jenkins']
+            return response.headers['X-jenkins']
         except KeyError:
-            msg = '%s is not a valid Jenkins URL.' %(self.baseurl)
+            msg = '%s is not a valid Jenkins URL.' % (self.baseurl)
             raise BadURL(msg)
index 371167a..0ff7ab9 100644 (file)
@@ -305,7 +305,7 @@ class TestJenkins(unittest.TestCase):
 
     @mock.patch.object(JenkinsBase, '_poll')
     @mock.patch.object(Jenkins, '_poll')
-    def test_get_version(self, _base_poll,_poll):
+    def test_get_version(self, _base_poll, _poll):
         class MockResponse(object):
              def __init__(self):
                  self.headers = {}
@@ -319,7 +319,7 @@ class TestJenkins(unittest.TestCase):
 
     @mock.patch.object(JenkinsBase, '_poll')
     @mock.patch.object(Jenkins, '_poll')
-    def test_get_version_exception(self, _base_poll,_poll):
+    def test_get_version_exception(self, _base_poll, _poll):
         class MockResponse(object):
             def __init__(self):
                 self.headers = {}
@@ -331,8 +331,8 @@ class TestJenkins(unittest.TestCase):
                     requester=mock_requester)
         with self.assertRaises(BadURL) as context:
             J.get_version()
-        msg = '%s is not a valid Jenkins URL.' %(base_url)
-        self.assertEqual(context.exception.message,msg)
+        msg = '%s is not a valid Jenkins URL.' % (base_url)
+        self.assertEqual(context.exception.message, msg)
 
 class TestJenkinsURLs(unittest.TestCase):