fix for #237
authorBhuvan Arumugam <bhuvan@apple.com>
Mon, 27 Jan 2014 15:01:13 +0000 (20:31 +0530)
committerBhuvan Arumugam <bhuvan@apple.com>
Mon, 27 Jan 2014 15:01:13 +0000 (20:31 +0530)
When the first job for the job was deleted and there is only one job (latest?)
in the build, get_job() API fail with TypeError.

This commit fixes this issue.
  https://github.com/salimfadhley/jenkinsapi/issues/237

jenkinsapi/job.py

index 2abcbfc6ad057b1b53b03b2cf37d8844b6bfe651..49f49720553c3110e65ecf688ca6166bbd495938 100644 (file)
@@ -103,7 +103,10 @@ class Job(JenkinsBase, MutableJenkinsThing):
             return data
         # do not call _buildid_for_type here: it would poll and do an infinite loop
         oldest_loaded_build_number = data["builds"][-1]["number"]
-        first_build_number = data["firstBuild"]["number"]
+        if not data['firstBuild']:
+            first_build_number = oldest_loaded_build_number
+        else:
+            first_build_number = data["firstBuild"]["number"]
         all_builds_loaded = (oldest_loaded_build_number == first_build_number)
         if all_builds_loaded:
             return data