drm/ili9486: Avoid spamming logs if probe is deferred

The GPIO request can fail and probe may be deferred. Thus,
the error message may be printed again and again. Avoid
this by replacing DRM_DEV_ERROR() by dev_err_probe().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210421163157.50949-4-andriy.shevchenko@linux.intel.com

diff --git a/drivers/gpu/drm/tiny/ili9486.c b/drivers/gpu/drm/tiny/ili9486.c
index 6422a7f67079b74b16ada88d9e63ec5673414172..75aa1476c66c3df4056d8ed0ce4ac37dfafd7d7e 100644 (file)
--- a/drivers/gpu/drm/tiny/ili9486.c
+++ b/drivers/gpu/drm/tiny/ili9486.c
@@ -206,16 +206,12 @@ static int ili9486_probe(struct spi_device *spi)
        drm = &dbidev->drm;
 
        dbi->reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
-       if (IS_ERR(dbi->reset)) {
-               DRM_DEV_ERROR(dev, "Failed to get gpio 'reset'\n");
-               return PTR_ERR(dbi->reset);
-       }
+       if (IS_ERR(dbi->reset))
+               return dev_err_probe(dev, PTR_ERR(dbi->reset), "Failed to get GPIO 'reset'\n");
 
        dc = devm_gpiod_get(dev, "dc", GPIOD_OUT_LOW);
-       if (IS_ERR(dc)) {
-               DRM_DEV_ERROR(dev, "Failed to get gpio 'dc'\n");
-               return PTR_ERR(dc);
-       }
+       if (IS_ERR(dc))
+               return dev_err_probe(dev, PTR_ERR(dc), "Failed to get GPIO 'dc'\n");
 
        dbidev->backlight = devm_of_find_backlight(dev);
        if (IS_ERR(dbidev->backlight))