[EFL] LayoutTestController needs implementation of goBack

https://bugs.webkit.org/show_bug.cgi?id=81914

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-03
Reviewed by Philippe Normand.

Tools:

Implement goBack() in EFL's LayoutTestController by calling
ewk_frame_back().

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::goBack):

LayoutTests:

Unskip loader/navigation-while-deferring-loads test in EFL now that
its LayoutTestController supports goBack().

* platform/efl/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 1654d0d..e64b484 100644 (file)
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,15 @@
+2012-04-03  Christophe Dumez  <christophe.dumez@intel.com>
+
+        [EFL] LayoutTestController needs implementation of goBack
+        https://bugs.webkit.org/show_bug.cgi?id=81914
+
+        Reviewed by Philippe Normand.
+
+        Unskip loader/navigation-while-deferring-loads test in EFL now that
+        its LayoutTestController supports goBack().
+
+        * platform/efl/Skipped:
+
 2012-04-03  Balazs Kelemen  <kbalazs@webkit.org>
 
         [Qt][WK2] Failing http/tests/plugins tests after reenabled plugins

diff --git a/LayoutTests/platform/efl/Skipped b/LayoutTests/platform/efl/Skipped
index b178e7b..4d279bb 100644 (file)
--- a/LayoutTests/platform/efl/Skipped
+++ b/LayoutTests/platform/efl/Skipped
@@ -587,9 +587,6 @@ storage/domstorage/localstorage/storagetracker
 # EFL's LayoutTestController does not implement setDomainRelaxationForbiddenForURLScheme
 http/tests/security/setDomainRelaxationForbiddenForURLScheme.html
 
-# EFL's LayoutTestController does not implement goBack
-loader/navigation-while-deferring-loads.html
-
 # EFL's LayoutTestController does not implement setDefersLoading
 loader/navigation-while-deferring-loads.html
 

diff --git a/Tools/ChangeLog b/Tools/ChangeLog
index d9b58d5..d4fb294 100644 (file)
--- a/Tools/ChangeLog
+++ b/Tools/ChangeLog
@@ -1,3 +1,16 @@
+2012-04-03  Christophe Dumez  <christophe.dumez@intel.com>
+
+        [EFL] LayoutTestController needs implementation of goBack
+        https://bugs.webkit.org/show_bug.cgi?id=81914
+
+        Reviewed by Philippe Normand.
+
+        Implement goBack() in EFL's LayoutTestController by calling
+        ewk_frame_back().
+
+        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
+        (LayoutTestController::goBack):
+
 2012-04-03  Alexander Shalamov  <alexander.shalamov@intel.com>
 
         [EFL] LayoutTestController needs implementation of pageSizeAndMarginsInPixels

diff --git a/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp b/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp
index b4b6450..088ebd5 100644 (file)
--- a/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp
+++ b/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp
@@ -608,8 +608,7 @@ void LayoutTestController::setDomainRelaxationForbiddenForURLScheme(bool, JSStri
 
 void LayoutTestController::goBack()
 {
-    // FIXME: implement to enable loader/navigation-while-deferring-loads.html
-    notImplemented();
+    ewk_frame_back(browser->mainFrame());
 }
 
 void LayoutTestController::setDefersLoading(bool)