lib: sbi_pmu: Firmware counters are always 64 bits wide
authorAnup Patel <apatel@ventanamicro.com>
Wed, 24 Aug 2022 06:14:40 +0000 (11:44 +0530)
committerAnup Patel <anup@brainfault.org>
Thu, 1 Sep 2022 11:23:18 +0000 (16:53 +0530)
As-per SBI specification, all firmware counters are always 64 bits
wide so let us update the SBI PMU implementation to reflect this fact.

Signed-off-by: Anup Patel <apatel@ventanamicro.com>
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
Reviewed-by: Atish Patra <atishp@rivosinc.com>
lib/sbi/sbi_pmu.c

index 250808e..1c01d34 100644 (file)
@@ -36,7 +36,7 @@ struct sbi_pmu_hw_event {
 /** Representation of a firmware event */
 struct sbi_pmu_fw_event {
        /* Current value of the counter */
-       unsigned long curr_count;
+       uint64_t curr_count;
 
        /* A flag indicating pmu event monitoring is started */
        bool bStarted;
@@ -719,8 +719,8 @@ int sbi_pmu_ctr_get_info(uint32_t cidx, unsigned long *ctr_info)
        } else {
                /* it's a firmware counter */
                cinfo.type = SBI_PMU_CTR_TYPE_FW;
-               /* Firmware counters are XLEN bits wide */
-               cinfo.width = BITS_PER_LONG - 1;
+               /* Firmware counters are always 64 bits wide */
+               cinfo.width = 63;
        }
 
        *ctr_info = cinfo.value;