misc: mei: client.c: return negative error code in mei_cl_write
authorSu Hui <suhui@nfschina.com>
Mon, 20 Nov 2023 09:55:23 +0000 (17:55 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 13 Dec 2023 17:45:29 +0000 (18:45 +0100)
[ Upstream commit 8f06aee8089cf42fd99a20184501bd1347ce61b9 ]

mei_msg_hdr_init() return negative error code, rets should be
'PTR_ERR(mei_hdr)' rather than '-PTR_ERR(mei_hdr)'.

Fixes: 0cd7c01a60f8 ("mei: add support for mei extended header.")
Signed-off-by: Su Hui <suhui@nfschina.com>
Link: https://lore.kernel.org/r/20231120095523.178385-1-suhui@nfschina.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/misc/mei/client.c

index 5c19097..75bc2a3 100644 (file)
@@ -2011,7 +2011,7 @@ ssize_t mei_cl_write(struct mei_cl *cl, struct mei_cl_cb *cb, unsigned long time
 
        mei_hdr = mei_msg_hdr_init(cb);
        if (IS_ERR(mei_hdr)) {
-               rets = -PTR_ERR(mei_hdr);
+               rets = PTR_ERR(mei_hdr);
                mei_hdr = NULL;
                goto err;
        }