Use RunContinuationsAsynchronously in SemaphoreSlim.WaitAsync (#22686)

SemaphoreSlim.Release shouldn't invoke arbitrary continuations as part of its invocation, so when it dequeues a task waiter and goes to complete it, rather than just calling TrySetResult, it queues the task to the thread pool to have TrySetResult invoked there.  Now that we have RunContinuationsAsynchronously, though, we can just use that functionality instead.  This has two main benefits:
1. We avoid queueing a work item entirely if there are no continuations from the task.  This might happen, for example, if the semaphore is released so quickly after waiting on it that the WaitAsync caller hasn't yet hooked up a continuation, in which case the await on the WaitAsync task will just see IsCompleted as true and continue running.
2. We avoid queueing a work item when the task represents a synchronous Wait, which happens if there's already a pending WaitAsync when Wait goes to block.  The main benefit here is avoiding potential thread pool starvation, if threads in the pool are blocked in such Waits, and previously another thread pool thread would have been needed to run the queued work item to complete the synchronous Wait.

diff --git a/src/System.Private.CoreLib/shared/System/Threading/SemaphoreSlim.cs b/src/System.Private.CoreLib/shared/System/Threading/SemaphoreSlim.cs
index 081e09d..d726353 100644 (file)
--- a/src/System.Private.CoreLib/shared/System/Threading/SemaphoreSlim.cs
+++ b/src/System.Private.CoreLib/shared/System/Threading/SemaphoreSlim.cs
@@ -76,13 +76,7 @@ namespace System.Threading
         private sealed class TaskNode : Task<bool>
         {
             internal TaskNode Prev, Next;
-            internal TaskNode() : base() { }
-
-            internal override void ExecuteFromThreadPool(Thread threadPoolThread)
-            {
-                bool setSuccessfully = TrySetResult(true);
-                Debug.Assert(setSuccessfully, "Should have been able to complete task");
-            }
+            internal TaskNode() : base((object)null, TaskCreationOptions.RunContinuationsAsynchronously) { }
         }
         #endregion
 
@@ -847,7 +841,7 @@ namespace System.Threading
                         // Get the next async waiter to release and queue it to be completed
                         var waiterTask = m_asyncHead;
                         RemoveAsyncWaiter(waiterTask); // ensures waiterTask.Next/Prev are null
-                        ThreadPool.UnsafeQueueUserWorkItemInternal(waiterTask, preferLocal: true);
+                        waiterTask.TrySetResult(result: true);
                     }
                 }
                 m_currentCount = currentCount;