wifi: mwifiex: fix endian conversion
authorJohannes Berg <johannes.berg@intel.com>
Sun, 4 Sep 2022 19:29:08 +0000 (21:29 +0200)
committerKalle Valo <kvalo@kernel.org>
Wed, 7 Sep 2022 08:02:59 +0000 (11:02 +0300)
Clearly the value should be converted and then compared,
not the result of the comparison be converted. No binary
changes on x86.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Reviewed-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220904212910.a32e45adb2b2.I8c966b07c0bf7be4485967b044d9dad3f4772a27@changeid
drivers/net/wireless/marvell/mwifiex/sta_event.c

index b95e90a..b6315fc 100644 (file)
@@ -623,7 +623,7 @@ mwifiex_fw_dump_info_event(struct mwifiex_private *priv,
                adapter->event_skb->data, event_skb->len);
        adapter->devdump_len += event_skb->len;
 
-       if (le16_to_cpu(fw_dump_hdr->type == FW_DUMP_INFO_ENDED)) {
+       if (le16_to_cpu(fw_dump_hdr->type) == FW_DUMP_INFO_ENDED) {
                mwifiex_dbg(adapter, MSG,
                            "receive end of transmission flag event!\n");
                goto upload_dump;