Apply clang-tidy fixes for readability-simplify-boolean-expr to MLIR (NFC)
authorMehdi Amini <joker.eph@gmail.com>
Mon, 7 Mar 2022 10:12:48 +0000 (10:12 +0000)
committerMehdi Amini <joker.eph@gmail.com>
Mon, 7 Mar 2022 10:41:45 +0000 (10:41 +0000)
mlir/lib/IR/AffineExpr.cpp
mlir/test/lib/Dialect/Tensor/TestTensorTransforms.cpp

index 2a3b981..44bf53b 100644 (file)
@@ -328,9 +328,7 @@ static bool isDivisibleBySymbol(AffineExpr expr, unsigned symbolPos,
          "unexpected opKind");
   switch (expr.getKind()) {
   case AffineExprKind::Constant:
-    if (expr.cast<AffineConstantExpr>().getValue())
-      return false;
-    return true;
+    return expr.cast<AffineConstantExpr>().getValue() == 0;
   case AffineExprKind::DimId:
     return false;
   case AffineExprKind::SymbolId:
index 7fdc185..2a2603a 100644 (file)
@@ -65,10 +65,7 @@ static void applyFoldConstantExtractSlicePatterns(FuncOp funcOp) {
 
         auto resultType = op.result().getType().cast<ShapedType>();
         constexpr int64_t kConstantFoldingMaxNumElements = 1024;
-        if (resultType.getNumElements() > kConstantFoldingMaxNumElements)
-          return false;
-
-        return true;
+        return resultType.getNumElements() <= kConstantFoldingMaxNumElements;
       };
 
   tensor::populateFoldConstantExtractSlicePatterns(patterns, controlFn);