s390/pci: fix sleeping in atomic during hotplug
authorSebastian Ott <sebott@linux.ibm.com>
Thu, 18 Oct 2018 09:11:08 +0000 (11:11 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 9 Jan 2019 16:14:48 +0000 (17:14 +0100)
commit 98dfd32620e970eb576ebce5ea39d905cb005e72 upstream.

When triggered by pci hotplug (PEC 0x306) clp_get_state is called
with spinlocks held resulting in the following warning:

zpci: n/a: Event 0x306 reconfigured PCI function 0x0
BUG: sleeping function called from invalid context at mm/page_alloc.c:4324
in_atomic(): 1, irqs_disabled(): 0, pid: 98, name: kmcheck
2 locks held by kmcheck/98:

Change the allocation to use GFP_ATOMIC.

Cc: stable@vger.kernel.org # 4.13+
Signed-off-by: Sebastian Ott <sebott@linux.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/s390/pci/pci_clp.c

index 93cd0f1..d8dfd64 100644 (file)
@@ -437,7 +437,7 @@ int clp_get_state(u32 fid, enum zpci_state *state)
        struct clp_state_data sd = {fid, ZPCI_FN_STATE_RESERVED};
        int rc;
 
-       rrb = clp_alloc_block(GFP_KERNEL);
+       rrb = clp_alloc_block(GFP_ATOMIC);
        if (!rrb)
                return -ENOMEM;