[libmultipath] ghost paths priorities are not set properly

Made some changes to honor the GHOST state while setting priorities.

Chandra Seetharaman, IBM

diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c
index f270f71..5ca832f 100644 (file)
--- a/libmultipath/discovery.c
+++ b/libmultipath/discovery.c
@@ -706,11 +706,11 @@ pathinfo (struct path *pp, vector hwtable, int mask)
                goto blank;
        
         /*
-         * Retrieve path priority for even PATH_DOWN paths if it has never
+         * Retrieve path priority even for not PATH_UP paths if it has never
          * been successfully obtained before.
          */
        if (mask & DI_PRIO &&
-           (pp->state != PATH_DOWN || pp->priority == PRIO_UNDEF))
+           (pp->state == PATH_UP || pp->priority == PRIO_UNDEF))
                get_prio(pp);
 
        if (mask & DI_WWID && !strlen(pp->wwid))

diff --git a/libmultipath/switchgroup.c b/libmultipath/switchgroup.c
index 757543f..9b84bc2 100644 (file)
--- a/libmultipath/switchgroup.c
+++ b/libmultipath/switchgroup.c
@@ -28,7 +28,7 @@ select_path_group (struct multipath * mpp)
                priority = 0;
 
                vector_foreach_slot (pgp->paths, pp, j) {
-                       if (pp->state != PATH_DOWN)
+                       if (pp->state == PATH_UP)
                                priority += pp->priority;
                }
                pgp->priority = priority;