tty: vcc: Drop unnecessary if block
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thu, 14 Jan 2021 17:57:17 +0000 (18:57 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 19 Feb 2021 00:21:10 +0000 (16:21 -0800)
If vcc_probe() succeeded dev_set_drvdata() is called with a non-NULL
value, and if vcc_probe() failed vcc_remove() isn't called.

So there is no way dev_get_drvdata() can return NULL in vcc_remove() and
the check can just go away.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/tty/vcc.c

index a4388a8..e2d6205 100644 (file)
@@ -681,9 +681,6 @@ static int vcc_remove(struct vio_dev *vdev)
 {
        struct vcc_port *port = dev_get_drvdata(&vdev->dev);
 
-       if (!port)
-               return -ENODEV;
-
        del_timer_sync(&port->rx_timer);
        del_timer_sync(&port->tx_timer);