trace: Cosmetic changes on fast-path tracing
authorLluís Vilanova <vilanova@ac.upc.edu>
Mon, 11 Jul 2016 10:53:35 +0000 (12:53 +0200)
committerStefan Hajnoczi <stefanha@redhat.com>
Mon, 18 Jul 2016 17:13:54 +0000 (18:13 +0100)
Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
trace/control-internal.h

index 59bcbb4..b326d88 100644 (file)
@@ -60,14 +60,17 @@ static inline bool trace_event_get_state_static(TraceEvent *ev)
     return ev->sstate;
 }
 
-static inline bool trace_event_get_state_dynamic_by_id(int id)
+static inline bool trace_event_get_state_dynamic_by_id(TraceEventID id)
 {
+    /* it's on fast path, avoid consistency checks (asserts) */
     return unlikely(trace_events_enabled_count) && trace_events_dstate[id];
 }
 
 static inline bool trace_event_get_state_dynamic(TraceEvent *ev)
 {
-    int id = trace_event_get_id(ev);
+    TraceEventID id;
+    assert(trace_event_get_state_static(ev));
+    id = trace_event_get_id(ev);
     return trace_event_get_state_dynamic_by_id(id);
 }