Fix SVACE defects 37/183037/5 accepted/tizen/unified/20180703.062143 submit/tizen/20180702.071334 submit/tizen/20180702.102759
authorSeungbae Shin <seungbae.shin@samsung.com>
Mon, 2 Jul 2018 02:29:06 +0000 (11:29 +0900)
committerSeungbae Shin <seungbae.shin@samsung.com>
Mon, 2 Jul 2018 05:58:21 +0000 (14:58 +0900)
[Version] 11.1.13
[Issue Type] SVACE

Change-Id: I0daf43bcc7ab9c83a0f507eccd6fd8e2ff46624e

packaging/pulseaudio-modules-tizen.spec
src/device-manager.c

index a8e1351..cf990b4 100644 (file)
@@ -1,6 +1,6 @@
 Name:             pulseaudio-modules-tizen
 Summary:          Pulseaudio modules for Tizen
-Version:          11.1.12
+Version:          11.1.13
 Release:          0
 Group:            Multimedia/Audio
 License:          LGPL-2.1+
index f04a9d8..c1eec03 100644 (file)
@@ -3340,7 +3340,11 @@ static void handle_get_supported_sample_rates(DBusConnection *conn, DBusMessage
         pa_dbus_send_error(conn, msg, DBUS_ERROR_NOT_SUPPORTED, "%s", "org.tizen.multimedia.audio.PolicyInternal");
         return;
     }
-    sink = pa_tz_device_get_sink(device, DEVICE_ROLE_NORMAL);
+    if (!(sink = pa_tz_device_get_sink(device, DEVICE_ROLE_NORMAL))) {
+        pa_log_error("could not get sink for normal role");
+        pa_dbus_send_error(conn, msg, DBUS_ERROR_INVALID_ARGS, "%s", "org.tizen.multimedia.audio.InvalidArgument");
+        return;
+    }
 
     dbus_message_iter_init_append(reply, &msg_iter);
     pa_assert_se(dbus_message_iter_open_container(&msg_iter, DBUS_TYPE_ARRAY, "(u)", &array_iter));
@@ -3388,7 +3392,11 @@ static void handle_set_sample_rate(DBusConnection *conn, DBusMessage *msg, void
         pa_dbus_send_error(conn, msg, DBUS_ERROR_NOT_SUPPORTED, "%s", "org.tizen.multimedia.audio.PolicyInternal");
         return;
     }
-    sink = pa_tz_device_get_sink(device, DEVICE_ROLE_NORMAL);
+    if (!(sink = pa_tz_device_get_sink(device, DEVICE_ROLE_NORMAL))) {
+        pa_log_error("could not get sink for normal role");
+        pa_dbus_send_error(conn, msg, DBUS_ERROR_INVALID_ARGS, "%s", "org.tizen.multimedia.audio.InvalidArgument");
+        return;
+    }
 
     /* use stream original sample rate if possible */
     if (sample_rate == 0) {
@@ -3463,7 +3471,11 @@ static void handle_get_sample_rate(DBusConnection *conn, DBusMessage *msg, void
         pa_dbus_send_error(conn, msg, DBUS_ERROR_NOT_SUPPORTED, "%s", "org.tizen.multimedia.audio.PolicyInternal");
         return;
     }
-    sink = pa_tz_device_get_sink(device, DEVICE_ROLE_NORMAL);
+    if (!(sink = pa_tz_device_get_sink(device, DEVICE_ROLE_NORMAL))) {
+        pa_log_error("could not get sink for normal role");
+        pa_dbus_send_error(conn, msg, DBUS_ERROR_INVALID_ARGS, "%s", "org.tizen.multimedia.audio.InvalidArgument");
+        return;
+    }
 
     pa_log_info("Get sample rate(%u) of the device(id:%d) successfully", sink->selected_sample_rate, device_id);
     pa_assert_se((reply = dbus_message_new_method_return(msg)));