[MLIR] Remove redundant library dependencies
authorStephen Neuendorffer <stephen.neuendorffer@xilinx.com>
Thu, 20 Feb 2020 06:56:38 +0000 (22:56 -0800)
committerStephen Neuendorffer <stephen.neuendorffer@xilinx.com>
Fri, 28 Feb 2020 19:35:18 +0000 (11:35 -0800)
In cmake, it is redundant to have a target list under target_link_libraries()
and add_dependency().  This patch removes the redundant dependency from
add_dependency().

Differential Revision: https://reviews.llvm.org/D74929

24 files changed:
mlir/lib/Analysis/CMakeLists.txt
mlir/lib/Conversion/AffineToStandard/CMakeLists.txt
mlir/lib/Conversion/LoopToStandard/CMakeLists.txt
mlir/lib/Conversion/LoopsToGPU/CMakeLists.txt
mlir/lib/Conversion/StandardToLLVM/CMakeLists.txt
mlir/lib/Dialect/AffineOps/CMakeLists.txt
mlir/lib/Dialect/FxpMathOps/CMakeLists.txt
mlir/lib/Dialect/GPU/CMakeLists.txt
mlir/lib/Dialect/LLVMIR/CMakeLists.txt
mlir/lib/Dialect/Linalg/Analysis/CMakeLists.txt
mlir/lib/Dialect/Linalg/EDSC/CMakeLists.txt
mlir/lib/Dialect/Linalg/IR/CMakeLists.txt
mlir/lib/Dialect/Linalg/Transforms/CMakeLists.txt
mlir/lib/Dialect/Linalg/Utils/CMakeLists.txt
mlir/lib/Dialect/LoopOps/CMakeLists.txt
mlir/lib/Dialect/QuantOps/CMakeLists.txt
mlir/lib/Dialect/SDBM/CMakeLists.txt
mlir/lib/Dialect/StandardOps/CMakeLists.txt
mlir/lib/EDSC/CMakeLists.txt
mlir/lib/IR/CMakeLists.txt
mlir/lib/Parser/CMakeLists.txt
mlir/lib/Pass/CMakeLists.txt
mlir/lib/Quantizer/CMakeLists.txt
mlir/test/lib/IR/CMakeLists.txt

index 23dcd0521e06cfc59091a98c14bcc5b4badfc2ab..8c049882d711816672b1d9d4f77a81505945a72c 100644 (file)
@@ -31,10 +31,8 @@ add_llvm_library(MLIRAnalysis
   LLVMSupport
   )
 add_dependencies(MLIRAnalysis
-  MLIRAffineOps
   MLIRCallOpInterfacesIncGen
   MLIRTypeInferOpInterfaceIncGen
-  MLIRLoopOps
   )
 
 add_llvm_library(MLIRLoopAnalysis
@@ -56,8 +54,6 @@ add_llvm_library(MLIRLoopAnalysis
   LLVMSupport
   )
 add_dependencies(MLIRLoopAnalysis
-  MLIRAffineOps
   MLIRCallOpInterfacesIncGen
   MLIRTypeInferOpInterfaceIncGen
-  MLIRLoopOps
   )
index 73ea74df5af348359d3fb6fc78876bbc89155271..8f4e00ef5fcc2b07f81aa041eb889ffe9b56943e 100644 (file)
@@ -14,12 +14,3 @@ add_mlir_conversion_library(MLIRAffineToStandard
   LLVMCore
   LLVMSupport
   )
-add_dependencies(
-  MLIRAffineToStandard
-
-  MLIRAffineOps
-  MLIRStandardOps
-  MLIRIR
-  LLVMCore
-  LLVMSupport
-)
index db17dd82ad9b01ba369726608e401ce56e933266..b027485fd604ce3d626f085feaaa6ada4e252494 100644 (file)
@@ -13,11 +13,3 @@ add_mlir_conversion_library(MLIRLoopToStandard
   LLVMCore
   LLVMSupport
   )
-add_dependencies(
-  MLIRLoopToStandard
-
-  MLIRLoopOps
-  MLIRTransforms
-  LLVMCore
-  LLVMSupport
-)
index 739c5b89b14b95df414ab85f6a440039f5dc8668..a23fc130714fc7ab02d954bc8a475298e2b18a4a 100644 (file)
@@ -1,4 +1,11 @@
-set(LIBS
+add_mlir_conversion_library(MLIRLoopsToGPU
+  LoopsToGPU.cpp
+  LoopsToGPUPass.cpp
+
+  ADDITIONAL_HEADER_DIRS
+  ${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/LoopsToGPU
+
+  LINK_LIBS
   MLIRAffineOps
   MLIRAffineToStandard
   MLIRGPU
@@ -11,16 +18,4 @@ set(LIBS
   MLIRTransforms
   MLIRTransformUtils
   LLVMSupport
-)
-
-add_mlir_conversion_library(MLIRLoopsToGPU
-  LoopsToGPU.cpp
-  LoopsToGPUPass.cpp
-
-  ADDITIONAL_HEADER_DIRS
-  ${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/LoopsToGPU
-
-  LINK_LIBS
-  ${LIBS}
   )
-add_dependencies(MLIRLoopsToGPU ${LIBS})
index 36f9d601ec80ece95d3835a88f1cd3e1d551301b..904ad37693cebb2f479c955ce41dd4293d3ddad0 100644 (file)
@@ -13,11 +13,3 @@ add_mlir_conversion_library(MLIRStandardToLLVM
   LLVMCore
   LLVMSupport
   )
-add_dependencies(
-  MLIRStandardToLLVM
-
-  MLIRLLVMIR
-  MLIRTransforms
-  LLVMCore
-  LLVMSupport
-)
index 749e7e283f3cfeb3e450f057a7926f6743f76251..51017de16c1cad8c99d8b6c389148756244a40c4 100644 (file)
@@ -13,10 +13,6 @@ add_mlir_dialect_library(MLIRAffineOps
   LLVMSupport
   )
 add_dependencies(MLIRAffineOps
-
   MLIRAffineOpsIncGen
-  MLIREDSC
-  MLIRIR
   MLIRLoopLikeInterfaceIncGen
-  MLIRStandardOps
   )
index e631fc67b534b322f4c500a852e1e5c0d08a5311..057290149a1be8e8fa064284c82b00202ddad1d6 100644 (file)
@@ -16,9 +16,5 @@ add_mlir_dialect_library(MLIRFxpMathOps
   LLVMSupport
   )
 add_dependencies(MLIRFxpMathOps
-                 MLIRFxpMathOpsIncGen
-                 MLIRQuantOps
-                 MLIRIR
-                 MLIRPass
-                 MLIRSupport
-                 MLIRStandardOps)
+  MLIRFxpMathOpsIncGen
+  )
index 595f8b737ac92c885bdb5a0f52862e8de3f6dff9..018291a7b7aeea625a226cf36bc38e2291a08a84 100644 (file)
@@ -21,10 +21,4 @@ add_mlir_dialect_library(MLIRGPU
   )
 add_dependencies(MLIRGPU
   MLIRGPUOpsIncGen
-  MLIREDSC
-  MLIRIR
-  MLIRLLVMIR
-  MLIRLoopOps
-  MLIRSupport
-  MLIRTransformUtils
-  LLVMSupport)
+  )
index eb32510c722a8c1bb5a83e7d747f9d974ab77783..71465c164eae844e51b1b5581c9ab752b7ea8a6e 100644 (file)
@@ -11,7 +11,10 @@ add_mlir_dialect_library(MLIRLLVMIR
   MLIRIR
   MLIRSupport
   )
-add_dependencies(MLIRLLVMIR MLIRLLVMOpsIncGen MLIRLLVMConversionsIncGen LLVMAsmParser LLVMCore LLVMSupport)
+add_dependencies(MLIRLLVMIR
+  MLIRLLVMOpsIncGen
+  MLIRLLVMConversionsIncGen
+  )
 
 add_mlir_dialect_library(MLIRNVVMIR
   IR/NVVMDialect.cpp
@@ -26,7 +29,11 @@ add_mlir_dialect_library(MLIRNVVMIR
   LLVMSupport
   LLVMCore
   )
-add_dependencies(MLIRNVVMIR MLIRNVVMOpsIncGen MLIRNVVMConversionsIncGen LLVMAsmParser LLVMCore LLVMSupport)
+add_dependencies(MLIRNVVMIR
+  MLIRNVVMOpsIncGen
+  MLIRNVVMConversionsIncGen
+  )
+
 
 
 add_mlir_dialect_library(MLIRROCDLIR
@@ -41,4 +48,7 @@ add_mlir_dialect_library(MLIRROCDLIR
   LLVMSupport
   MLIRIR
   )
-add_dependencies(MLIRROCDLIR MLIRROCDLOpsIncGen MLIRROCDLConversionsIncGen LLVMAsmParser LLVMCore LLVMSupport)
+add_dependencies(MLIRROCDLIR
+  MLIRROCDLOpsIncGen
+  MLIRROCDLConversionsIncGen
+  )
index 629e071e7b5773ce9f6129383a8a241d0deaa4c0..53a9c79fd1bc4cf34ffa8d193cba85943afdbd3c 100644 (file)
@@ -1,21 +1,15 @@
-set(LIBS
-  MLIRIR
-  MLIRLinalgOps
-  MLIRStandardOps
-  LLVMSupport
-  )
-
-
 add_mlir_dialect_library(MLIRLinalgAnalysis
   DependenceAnalysis.cpp
   
   ADDITIONAL_HEADER_DIRS
   ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Linalg
+
   DEPENDS
   intrinsics_gen
 
   LINK_LIBS
-  ${LIBS}
+  MLIRIR
+  MLIRLinalgOps
+  MLIRStandardOps
+  LLVMSupport
   )
-
-add_dependencies(MLIRLinalgAnalysis ${LIBS})
index 6c0cc3cfe617090581da0acae514e71b4d950e19..e6b347971eed031c1fcfecb13a52a90e1ed50e8e 100644 (file)
@@ -1,24 +1,18 @@
-set(LIBS
-
-  MLIREDSC
-  MLIRIR
-  MLIRAffineOps
-  MLIRLinalgOps
-  MLIRLoopOps
-  MLIRStandardOps
-  LLVMSupport
-  )
-
 add_mlir_dialect_library(MLIRLinalgEDSC
   Builders.cpp
 
   ADDITIONAL_HEADER_DIRS
   ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Linalg
+
   DEPENDS
   intrinsics_gen
 
   LINK_LIBS
-  ${LIBS}
+  MLIREDSC
+  MLIRIR
+  MLIRAffineOps
+  MLIRLinalgOps
+  MLIRLoopOps
+  MLIRStandardOps
+  LLVMSupport
   )
-
-add_dependencies(MLIRLinalgEDSC ${LIBS})
index 3988daa66b8c938cb54dc9298f67bab0230e6bf2..70daa7c52ab5a248e234032317741f96ae4b2c73 100644 (file)
@@ -1,16 +1,10 @@
-set(LIBS
-  MLIRIR
-  MLIRStandardOps
-  MLIRSupport
-  LLVMSupport
-  )
-
 add_mlir_dialect_library(MLIRLinalgOps
   LinalgOps.cpp
   LinalgTypes.cpp
 
   ADDITIONAL_HEADER_DIRS
   ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Linalg
+
   DEPENDS
   intrinsics_gen
 
@@ -20,10 +14,7 @@ add_mlir_dialect_library(MLIRLinalgOps
   MLIRSupport
   LLVMSupport
   )
-
 add_dependencies(MLIRLinalgOps
-
-  ${LIBS}
   MLIRLinalgOpsIncGen
   MLIRLinalgStructuredOpsIncGen
   MLIRLinalgStructuredOpsInterfaceIncGen
index 5c1df0451c103edc28ef0652e6867a83019091ec..7287324faa6b6f540c699897ac39e2293444669c 100644 (file)
@@ -1,5 +1,16 @@
-set(LIBS
+add_mlir_dialect_library(MLIRLinalgTransforms
+  Fusion.cpp
+  LinalgTransforms.cpp
+  LinalgToLoops.cpp
+  Promotion.cpp
+  Tiling.cpp
 
+  ADDITIONAL_HEADER_DIRS
+  ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Linalg
+  DEPENDS
+  intrinsics_gen
+
+  LINK_LIBS
   MLIRAffineOps
   MLIRAnalysis
   MLIREDSC
@@ -16,25 +27,6 @@ set(LIBS
   MLIRVectorOps
   LLVMSupport
   )
-
-add_mlir_dialect_library(MLIRLinalgTransforms
-  Fusion.cpp
-  LinalgTransforms.cpp
-  LinalgToLoops.cpp
-  Promotion.cpp
-  Tiling.cpp
-
-  ADDITIONAL_HEADER_DIRS
-  ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Linalg
-  DEPENDS
-  intrinsics_gen
-
-  LINK_LIBS
-  ${LIBS}
-  )
-
 add_dependencies(MLIRLinalgTransforms
-
-  ${LIBS}
   MLIRLinalgTransformPatternsIncGen
   )
index 98d5d9aed76817a7079f0a537db8db8b5b553c37..754688ff2688397802b1c3abcd183665c3cc9a8c 100644 (file)
@@ -1,4 +1,13 @@
-set(LIBS
+add_mlir_dialect_library(MLIRLinalgUtils
+  Utils.cpp
+
+  ADDITIONAL_HEADER_DIRS
+  ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Linalg
+
+  DEPENDS
+  intrinsics_gen
+
+  LINK_LIBS
   MLIRAffineOps
   MLIREDSC
   MLIRIR
@@ -9,17 +18,3 @@ set(LIBS
   MLIRTransformUtils
   LLVMSupport
   )
-  
-add_mlir_dialect_library(MLIRLinalgUtils
-
-  Utils.cpp
-
-  ADDITIONAL_HEADER_DIRS
-  ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/Linalg
-  DEPENDS
-  intrinsics_gen
-
-  LINK_LIBS
-  ${LIBS})
-
-add_dependencies(MLIRLinalgUtils ${LIBS})
index e228654ced25a5df5ab1db206ce966f9d5ad5323..635bbdeb58a6abb6646683fc58d34015fb1fe20c 100644 (file)
@@ -13,12 +13,8 @@ add_mlir_dialect_library(MLIRLoopOps
   LLVMSupport
   )
 add_dependencies(MLIRLoopOps
-
-  MLIREDSC
   MLIRLoopLikeInterfaceIncGen
   MLIRLoopOpsIncGen
-  MLIRStandardOps
-  LLVMSupport
   )
 
 add_subdirectory(Transforms)
index 14acb913ec8534951e4aad370610a2da78b9143a..c9d104114465c8f314c1626b1d64fc6ab48c39df 100644 (file)
@@ -21,8 +21,5 @@ add_mlir_dialect_library(MLIRQuantOps
   LLVMSupport
   )
 add_dependencies(MLIRQuantOps
-                 MLIRIR
-                 MLIRPass
-                 MLIRQuantOpsIncGen
-                 MLIRSupport
-                 MLIRStandardOps)
+  MLIRQuantOpsIncGen
+  )
index b75e257daf77df5b5a703e9286499cf45642a444..2c753d677f1097143216bf318945a67f12012c66 100644 (file)
@@ -10,4 +10,3 @@ add_mlir_dialect_library(MLIRSDBM
   MLIRSupport
   LLVMSupport
   )
-add_dependencies(MLIRSDBM MLIRIR)
index e802e0c0fb034890d3f413b3b443dfa3bc8ddd8a..acf47df6eb8d982caeb3a2e8c8d80c7b5fa7e2df 100644 (file)
@@ -14,10 +14,6 @@ add_mlir_dialect_library(MLIRStandardOps
   LLVMSupport
   )
 add_dependencies(MLIRStandardOps
-
   MLIRCallOpInterfacesIncGen
-  MLIREDSC
-  MLIRIR
   MLIRStandardOpsIncGen
-  LLVMSupport
   )
index 3d0290a61dc1e7c0b044739dde2300ff81115110..660efc5bccee961ac464f373f116289b7152bd3d 100644 (file)
@@ -27,4 +27,3 @@ add_llvm_library(MLIREDSCInterface
   MLIRParser
   LLVMSupport
   )
-add_dependencies(MLIREDSCInterface MLIRIR)
index 8802f6c986d2f4b92a24557ac699949d324d74d0..f3788e2ca0ab897e1d2ff23caf03b1f3d797d837 100644 (file)
@@ -10,4 +10,7 @@ add_llvm_library(MLIRIR
   LLVMSupport
   ${LLVM_PTHREAD_LIB}
   )
-add_dependencies(MLIRIR MLIRCallOpInterfacesIncGen MLIROpAsmInterfacesIncGen MLIRSupport LLVMSupport)
+add_dependencies(MLIRIR
+  MLIRCallOpInterfacesIncGen
+  MLIROpAsmInterfacesIncGen
+  )
index 36ede655daaa4d08f7a5a95b31ddc5caacd93a7e..978a6748f22e896e0cdfbffe33de4485f6354891 100644 (file)
@@ -11,4 +11,3 @@ add_llvm_library(MLIRParser
   MLIRAnalysis
   LLVMSupport
   )
-add_dependencies(MLIRParser MLIRIR MLIRAnalysis)
index 54407d98503ba61655d40c0a9ebc9a8c7f6ce68f..9df404c3653616879f25784568de030529425ab0 100644 (file)
@@ -12,4 +12,3 @@ add_llvm_library(MLIRPass
   LLVMIRReader
   LLVMSupport
   )
-add_dependencies(MLIRPass MLIRAnalysis MLIRIR LLVMSupport)
index d87b7da0a10eae6426477ee6f70be532050b873f..34d0effc9362ceb940864e02fa9a8fd8761f49f6 100644 (file)
@@ -18,12 +18,6 @@ add_llvm_library(MLIRQuantizerSupport
   LLVMSupport
   )
 
-add_dependencies(MLIRQuantizerSupport
-                 MLIRIR
-                 MLIRQuantOps
-                 MLIRSupport
-                 MLIRStandardOps)
-
 # Configurations.
 add_llvm_library(MLIRQuantizerFxpMathConfig
   Configurations/FxpMathConfig.cpp
@@ -41,8 +35,8 @@ add_llvm_library(MLIRQuantizerFxpMathConfig
   )
 
 add_dependencies(MLIRQuantizerFxpMathConfig
-                 MLIRFxpMathOpsIncGen
-                 MLIRQuantizerSupport)
+  MLIRFxpMathOpsIncGen
+  )
 
 # Transforms.
 add_llvm_library(MLIRQuantizerTransforms
@@ -62,7 +56,3 @@ add_llvm_library(MLIRQuantizerTransforms
   MLIRTransformUtils
   LLVMSupport
   )
-add_dependencies(MLIRQuantizerTransforms
-  MLIRQuantizerFxpMathConfig
-  MLIRQuantizerSupport
-  MLIRPass)
index 355faccc692753c64774f0773e2bd454312d638f..121ba4485ca5e1f3803d93ed7d5996cdac972462 100644 (file)
@@ -13,6 +13,3 @@ add_llvm_library(MLIRTestIR
   )
 include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../TestDialect)
 include_directories(${CMAKE_CURRENT_BINARY_DIR}/../TestDialect)
-add_dependencies(MLIRTestIR
-  MLIRTestDialect
-  )