Use system icu in Tizen builds.
authorAntonio Gomes <a1.gomes@samsung.com>
Thu, 17 Dec 2015 15:30:12 +0000 (07:30 -0800)
committerYoungsoo Choi <kenshin.choi@samsung.com>
Tue, 10 Jul 2018 07:55:23 +0000 (07:55 +0000)
After coordinating with Platform team, icu version was
bumped from 51 to 54, which is the base version of icu
bundled with chromium (third_party/icu).

It turns out that icu-54 is not enough to build chromium
because it lacks TimeZone::detectHostTimeZone API used in
content/browser/time_zone_monitor.cc.

After some more investigation, it was figured out that icu bundled
with chromium is manually patched (see third_party/icu/patches).
It was request to the platform team to apply two patches then
as part of package build:
- third_party/icu/patches/tzdetect{2}.patch

It is now possible to build chromium m47 with system icu.
This saves about 1.5Mb in libchromium-efl.so size (stripped).

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12893

Reviewed by: sns.park

Change-Id: I90ce970b444c7865d7769a219949a699deb9b893
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
tizen_src/build/gyp_chromiumefl.sh

index 18f8d73..eb1a2ba 100755 (executable)
@@ -183,12 +183,7 @@ add_gbs_flags() {
                -Duse_system_minizip=1
                -Duse_system_speex=1
                -Duse_system_zlib=1
-              "
-
-  # [M44_2403] Temporary changing which uses the chromium 'ICU' instead of the system 'ICU'
-  #            for switching to new chromium
-  #            FIXME: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13290
-  SYSTEM_DEPS="-Duse_system_icu=0
+               -Duse_system_icu=1
               "
 
   if [ "$target" == "mobile" ]; then