gtp: include role in link info
authorJonas Bonn <jonas@norrbonn.se>
Wed, 3 Feb 2021 07:08:01 +0000 (08:08 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 4 Feb 2021 17:29:58 +0000 (09:29 -0800)
Querying link info for the GTP interface doesn't reveal in which "role" the
device is set to operate.  Include this information in the info query
result.

Signed-off-by: Jonas Bonn <jonas@norrbonn.se>
Acked-by: Harald Welte <laforge@gnumonks.org>
Acked-by: Pravin B Shelar <pshelar@ovn.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/gtp.c

index 5a048f0..5682d3b 100644 (file)
@@ -728,7 +728,8 @@ static int gtp_validate(struct nlattr *tb[], struct nlattr *data[],
 
 static size_t gtp_get_size(const struct net_device *dev)
 {
-       return nla_total_size(sizeof(__u32));   /* IFLA_GTP_PDP_HASHSIZE */
+       return nla_total_size(sizeof(__u32)) + /* IFLA_GTP_PDP_HASHSIZE */
+               nla_total_size(sizeof(__u32)); /* IFLA_GTP_ROLE */
 }
 
 static int gtp_fill_info(struct sk_buff *skb, const struct net_device *dev)
@@ -737,6 +738,8 @@ static int gtp_fill_info(struct sk_buff *skb, const struct net_device *dev)
 
        if (nla_put_u32(skb, IFLA_GTP_PDP_HASHSIZE, gtp->hash_size))
                goto nla_put_failure;
+       if (nla_put_u32(skb, IFLA_GTP_ROLE, gtp->role))
+               goto nla_put_failure;
 
        return 0;