isolate, "Invalid event object")));
}
-void WebContents::BeginFrameSubscription(
- mate::Arguments* args) {
- FrameSubscriber::FrameCaptureCallback callback;
+void WebContents::BeginFrameSubscription(mate::Arguments* args) {
bool only_dirty = false;
+ FrameSubscriber::FrameCaptureCallback callback;
+ args->GetNext(&only_dirty);
if (!args->GetNext(&callback)) {
- args->GetNext(&only_dirty);
- if (!args->GetNext(&callback))
- args->ThrowTypeError("'callback' must be defined");
+ args->ThrowError();
+ return;
}
const auto view = web_contents()->GetRenderWidgetHostView();
#include "atom/browser/api/frame_subscriber.h"
#include "base/bind.h"
-#include "atom/common/node_includes.h"
#include "atom/common/native_mate_converters/gfx_converter.h"
+#include "atom/common/node_includes.h"
#include "content/public/browser/render_widget_host.h"
namespace atom {
content::RenderWidgetHostView* view,
const FrameCaptureCallback& callback,
bool only_dirty)
- : isolate_(isolate), view_(view), callback_(callback),
- only_dirty_(only_dirty), weak_factory_(this) {
+ : isolate_(isolate),
+ view_(view),
+ callback_(callback),
+ only_dirty_(only_dirty),
+ weak_factory_(this) {
}
bool FrameSubscriber::ShouldCaptureFrame(
}
void FrameSubscriber::OnFrameDelivered(const FrameCaptureCallback& callback,
- const gfx::Rect& damage_rect, const SkBitmap& bitmap,
- content::ReadbackResponse response) {
+ const gfx::Rect& damage_rect,
+ const SkBitmap& bitmap,
+ content::ReadbackResponse response) {
if (response != content::ReadbackResponse::READBACK_SUCCESS)
return;
rgb_arr_size);
v8::Local<v8::Value> damage =
- mate::Converter<gfx::Rect>::ToV8(isolate_, damage_rect);
+ mate::Converter<gfx::Rect>::ToV8(isolate_, damage_rect);
callback_.Run(buffer.ToLocalChecked(), damage);
}
class FrameSubscriber : public content::RenderWidgetHostViewFrameSubscriber {
public:
using FrameCaptureCallback =
- base::Callback<void(v8::Local<v8::Value>, v8::Local<v8::Value>)>;
+ base::Callback<void(v8::Local<v8::Value>, v8::Local<v8::Value>)>;
FrameSubscriber(v8::Isolate* isolate,
content::RenderWidgetHostView* view,
private:
void OnFrameDelivered(const FrameCaptureCallback& callback,
- const gfx::Rect& damage_rect, const SkBitmap& bitmap,
- content::ReadbackResponse response);
+ const gfx::Rect& damage_rect,
+ const SkBitmap& bitmap,
+ content::ReadbackResponse response);
v8::Isolate* isolate_;
content::RenderWidgetHostView* view_;
### `webContents.beginFrameSubscription([onlyDirty ,]callback)`
-* `onlyDirty` Boolean
+* `onlyDirty` Boolean (optional) - Defaults to `false`
* `callback` Function
Begin subscribing for presentation events and captured frames, the `callback`