staging: rtl8192e: Remove entry .tx_check_stuc.. from struct rtl819x_ops

Remove entry .tx_check_stuck_handler and replace it with function name
rtl92e_is_tx_stuck. This increases readability of the code.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/f58cc7b39f4a6bce0606bdd90a706b35b87d8256.1677010997.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
index 3323bdf..410c038 100644 (file)
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
@@ -30,7 +30,6 @@ static const struct rtl819x_ops rtl819xp_ops = {
        .link_change                    = rtl92e_link_change,
        .rx_command_packet_handler = NULL,
        .irq_clear                      = rtl92e_clear_irq,
-       .tx_check_stuck_handler = rtl92e_is_tx_stuck,
        .rx_check_stuck_handler = rtl92e_is_rx_stuck,
 };
 
@@ -1055,7 +1054,7 @@ static enum reset_type _rtl92e_tx_check_stuck(struct net_device *dev)
        spin_unlock_irqrestore(&priv->irq_th_lock, flags);
 
        if (bCheckFwTxCnt) {
-               if (priv->ops->tx_check_stuck_handler(dev))
+               if (rtl92e_is_tx_stuck(dev))
                        return RESET_TYPE_SILENT;
        }
 

diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
index d3558bf..87be8aa 100644 (file)
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
@@ -211,7 +211,6 @@ struct rtl819x_ops {
                                          struct sk_buff *skb,
                                          struct rx_desc *pdesc);
        void (*irq_clear)(struct net_device *dev);
-       bool (*tx_check_stuck_handler)(struct net_device *dev);
        bool (*rx_check_stuck_handler)(struct net_device *dev);
 };