HID: cp2112: Use BIT() in GPIO setter and getter
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 3 Jul 2023 18:52:19 +0000 (21:52 +0300)
committerBenjamin Tissoires <bentiss@kernel.org>
Fri, 28 Jul 2023 15:05:48 +0000 (17:05 +0200)
Use BIT() in GPIO setter and getter for the sake of consistency
with GENMASK() usage elsewhere in the driver.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230703185222.50554-10-andriy.shevchenko@linux.intel.com
Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
drivers/hid/hid-cp2112.c

index 37ed7fc..2eebb2b 100644 (file)
@@ -197,7 +197,7 @@ static int cp2112_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
                goto exit;
        }
 
-       buf[1] &= ~(1 << offset);
+       buf[1] &= ~BIT(offset);
        buf[2] = gpio_push_pull;
 
        ret = hid_hw_raw_request(hdev, CP2112_GPIO_CONFIG, buf,
@@ -228,7 +228,7 @@ static void cp2112_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
 
        buf[0] = CP2112_GPIO_SET;
        buf[1] = value ? CP2112_GPIO_ALL_GPIO_MASK : 0;
-       buf[2] = 1 << offset;
+       buf[2] = BIT(offset);
 
        ret = hid_hw_raw_request(hdev, CP2112_GPIO_SET, buf,
                                 CP2112_GPIO_SET_LENGTH, HID_FEATURE_REPORT,