remote.c: Add missing cast

Fixes in C++:

/home/emaisin/src/binutils-gdb/gdb/remote.c: In function ‘void start_thread(gdb_xml_parser*, const gdb_xml_element*, void*, VEC_gdb_xml_value_s*)’:
/home/emaisin/src/binutils-gdb/gdb/remote.c:2975:59: error: invalid conversion from ‘void*’ to ‘const char*’ [-fpermissive]
   item.name = attr != NULL ? (char *) xstrdup (attr->value) : NULL;
                                                           ^
In file included from /home/emaisin/src/binutils-gdb/gdb/common/common-defs.h:64:0,
                 from /home/emaisin/src/binutils-gdb/gdb/defs.h:28,
                 from /home/emaisin/src/binutils-gdb/gdb/remote.c:22:
/home/emaisin/src/binutils-gdb/gdb/../include/libiberty.h:323:14: error:   initializing argument 1 of ‘char* xstrdup(const char*)’ [-fpermissive]
 extern char *xstrdup (const char *) ATTRIBUTE_MALLOC ATTRIBUTE_RETURNS_NONNULL;
              ^
make[2]: *** [remote.o] Error 1

gdb/ChangeLog:

	* remote.c (start_thread): Add cast.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 54642e1..fd84223 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2015-11-27  Simon Marchi  <simon.marchi@ericsson.com>
+
+       * remote.c (start_thread): Add cast.
+
 2015-11-27  Yao Qi  <yao.qi@linaro.org>
 
        * nat/aarch64-linux-hw-point.c (aarch64_dr_state_remove_one_point):

diff --git a/gdb/remote.c b/gdb/remote.c
index a80e548..90be8b6 100644 (file)
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -2972,7 +2972,7 @@ start_thread (struct gdb_xml_parser *parser,
     item.core = -1;
 
   attr = xml_find_attribute (attributes, "name");
-  item.name = attr != NULL ? xstrdup (attr->value) : NULL;
+  item.name = attr != NULL ? xstrdup ((const char *) attr->value) : NULL;
 
   item.extra = 0;