drm/<drivers>: Drop fbdev info flags
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 6 Jul 2017 12:57:35 +0000 (14:57 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 26 Jul 2017 11:22:40 +0000 (13:22 +0200)
- FBINFO_CAN_FORCE_OUTPUT has been a lie ever since we nerfed&removed
  the entire panic handling code in our fbdev emulation. We might
  restore kms panic output, but not through the bazillion of legacy
  code layers called fbdev/fbcon, there's just no way to make that
  work safely.

- With the module check change FBINFO_DEFAULT is always 0, so can be
  removed too.

That removes another change to cargo-cult stuff in kms drivers, yay!

Reviewed-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20170706125735.28299-5-daniel.vetter@ffwll.ch
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
15 files changed:
drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
drivers/gpu/drm/armada/armada_fbdev.c
drivers/gpu/drm/ast/ast_fb.c
drivers/gpu/drm/bochs/bochs_fbdev.c
drivers/gpu/drm/cirrus/cirrus_fbdev.c
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c
drivers/gpu/drm/i915/intel_fbdev.c
drivers/gpu/drm/mgag200/mgag200_fb.c
drivers/gpu/drm/msm/msm_fbdev.c
drivers/gpu/drm/omapdrm/omap_fbdev.c
drivers/gpu/drm/qxl/qxl_fb.c
drivers/gpu/drm/radeon/radeon_fb.c
drivers/gpu/drm/udl/udl_fb.c
drivers/gpu/drm/virtio/virtgpu_fb.c
drivers/gpu/drm/vmwgfx/vmwgfx_fb.c

index c0d8c6f..1c57fef 100644 (file)
@@ -245,7 +245,6 @@ static int amdgpufb_create(struct drm_fb_helper *helper,
 
        drm_fb_helper_fill_fix(info, fb->pitches[0], fb->format->depth);
 
-       info->flags = FBINFO_DEFAULT | FBINFO_CAN_FORCE_OUTPUT;
        info->fbops = &amdgpufb_ops;
 
        tmp = amdgpu_bo_gpu_offset(abo) - adev->mc.vram_start;
index 602dfea..5b479b0 100644 (file)
@@ -81,7 +81,6 @@ static int armada_fb_create(struct drm_fb_helper *fbh,
 
        strlcpy(info->fix.id, "armada-drmfb", sizeof(info->fix.id));
        info->par = fbh;
-       info->flags = FBINFO_DEFAULT | FBINFO_CAN_FORCE_OUTPUT;
        info->fbops = &armada_fb_ops;
        info->fix.smem_start = obj->phys_addr;
        info->fix.smem_len = obj->obj.size;
index 4ad4acd..53ca6d0 100644 (file)
@@ -231,7 +231,6 @@ static int astfb_create(struct drm_fb_helper *helper,
 
        strcpy(info->fix.id, "astdrmfb");
 
-       info->flags = FBINFO_DEFAULT | FBINFO_CAN_FORCE_OUTPUT;
        info->fbops = &astfb_ops;
 
        info->apertures->ranges[0].base = pci_resource_start(dev->pdev, 0);
index 49d5a2b..14eb8d0 100644 (file)
@@ -118,7 +118,6 @@ static int bochsfb_create(struct drm_fb_helper *helper,
 
        strcpy(info->fix.id, "bochsdrmfb");
 
-       info->flags = FBINFO_DEFAULT;
        info->fbops = &bochsfb_ops;
 
        drm_fb_helper_fill_fix(info, fb->pitches[0], fb->format->depth);
index 7fa58ee..c695861 100644 (file)
@@ -215,7 +215,6 @@ static int cirrusfb_create(struct drm_fb_helper *helper,
 
        strcpy(info->fix.id, "cirrusdrmfb");
 
-       info->flags = FBINFO_DEFAULT;
        info->fbops = &cirrusfb_ops;
 
        drm_fb_helper_fill_fix(info, fb->pitches[0], fb->format->depth);
index f5ac80d..9740eed 100644 (file)
@@ -131,7 +131,6 @@ static int hibmc_drm_fb_create(struct drm_fb_helper *helper,
 
        strcpy(info->fix.id, "hibmcdrmfb");
 
-       info->flags = FBINFO_DEFAULT;
        info->fbops = &hibmc_drm_fb_ops;
 
        drm_fb_helper_fill_fix(info, hi_fbdev->fb->fb.pitches[0],
index 460ca0b..ec61980 100644 (file)
@@ -232,7 +232,6 @@ static int intelfb_create(struct drm_fb_helper *helper,
 
        strcpy(info->fix.id, "inteldrmfb");
 
-       info->flags = FBINFO_DEFAULT | FBINFO_CAN_FORCE_OUTPUT;
        info->fbops = &intelfb_ops;
 
        /* setup aperture base/size for vesafb takeover */
index 5d3b1fa..e94d78a 100644 (file)
@@ -210,7 +210,6 @@ static int mgag200fb_create(struct drm_fb_helper *helper,
 
        strcpy(info->fix.id, "mgadrmfb");
 
-       info->flags = FBINFO_DEFAULT | FBINFO_CAN_FORCE_OUTPUT;
        info->fbops = &mgag200fb_ops;
 
        /* setup aperture base/size for vesafb takeover */
index 5ecf4ff..9c00fed 100644 (file)
@@ -143,7 +143,6 @@ static int msm_fbdev_create(struct drm_fb_helper *helper,
        helper->fb = fb;
 
        fbi->par = helper;
-       fbi->flags = FBINFO_DEFAULT;
        fbi->fbops = &msm_fb_ops;
 
        strcpy(fbi->fix.id, "msm");
index daf81a0..9273118 100644 (file)
@@ -184,7 +184,6 @@ static int omap_fbdev_create(struct drm_fb_helper *helper,
        helper->fb = fb;
 
        fbi->par = helper;
-       fbi->flags = FBINFO_DEFAULT;
        fbi->fbops = &omap_fb_ops;
 
        strcpy(fbi->fix.id, MODULE_NAME);
index 69e7359..844c4a3 100644 (file)
@@ -275,7 +275,6 @@ static int qxlfb_create(struct qxl_fbdev *qfbdev,
 
        drm_fb_helper_fill_fix(info, fb->pitches[0], fb->format->depth);
 
-       info->flags = FBINFO_DEFAULT;
        info->fbops = &qxlfb_ops;
 
        /*
index 356ad90..e141fcd 100644 (file)
@@ -264,7 +264,6 @@ static int radeonfb_create(struct drm_fb_helper *helper,
 
        drm_fb_helper_fill_fix(info, fb->pitches[0], fb->format->depth);
 
-       info->flags = FBINFO_DEFAULT | FBINFO_CAN_FORCE_OUTPUT;
        info->fbops = &radeonfb_ops;
 
        tmp = radeon_bo_gpu_offset(rbo) - rdev->mc.vram_start;
index 4a65003..a5c54dc 100644 (file)
@@ -393,7 +393,6 @@ static int udlfb_create(struct drm_fb_helper *helper,
        info->fix.smem_len = size;
        info->fix.smem_start = (unsigned long)ufbdev->ufb.obj->vmapping;
 
-       info->flags = FBINFO_DEFAULT | FBINFO_CAN_FORCE_OUTPUT;
        info->fbops = &udlfb_ops;
        drm_fb_helper_fill_fix(info, fb->pitches[0], fb->format->depth);
        drm_fb_helper_fill_var(info, &ufbdev->helper, sizes->fb_width, sizes->fb_height);
index 33df067..046e28b 100644 (file)
@@ -273,7 +273,6 @@ static int virtio_gpufb_create(struct drm_fb_helper *helper,
        vfbdev->helper.fb = fb;
 
        strcpy(info->fix.id, "virtiodrmfb");
-       info->flags = FBINFO_DEFAULT;
        info->fbops = &virtio_gpufb_ops;
        info->pixmap.flags = FB_PIXMAP_SYSTEM;
 
index 6f4cb46..d23a18a 100644 (file)
@@ -779,7 +779,6 @@ int vmw_fb_init(struct vmw_private *vmw_priv)
        info->screen_base = (char __iomem *)par->vmalloc;
        info->screen_size = fb_size;
 
-       info->flags = FBINFO_DEFAULT;
        info->fbops = &vmw_fb_ops;
 
        /* 24 depth per default */