drm/bridge: ti-sn65dsi86: Add some 100 us delays
authorDouglas Anderson <dianders@chromium.org>
Fri, 30 Jul 2021 15:46:02 +0000 (08:46 -0700)
committerSam Ravnborg <sam@ravnborg.org>
Sat, 31 Jul 2021 18:03:24 +0000 (20:03 +0200)
The manual has always said that we need 100 us delays in a few
places. Though it hasn't seemed to be a big deal to skip these, let's
add them in case it makes something happier.

NOTE: this fixes no known issues but it seems good to make it right.

Fixes: a095f15c00e2 ("drm/bridge: add support for sn65dsi86 bridge driver")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Acked-by: Robert Foss <robert.foss@linaro.org>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210730084534.v2.3.I842d483139531aa4651da8338512fdf0171ff23c@changeid
drivers/gpu/drm/bridge/ti-sn65dsi86.c

index 5e93207..cd0fccd 100644 (file)
@@ -307,6 +307,9 @@ static int __maybe_unused ti_sn65dsi86_resume(struct device *dev)
                return ret;
        }
 
+       /* td2: min 100 us after regulators before enabling the GPIO */
+       usleep_range(100, 110);
+
        gpiod_set_value(pdata->enable_gpio, 1);
 
        /*
@@ -1096,6 +1099,9 @@ static void ti_sn_bridge_pre_enable(struct drm_bridge *bridge)
 
        if (!pdata->refclk)
                ti_sn65dsi86_enable_comms(pdata);
+
+       /* td7: min 100 us after enable before DSI data */
+       usleep_range(100, 110);
 }
 
 static void ti_sn_bridge_post_disable(struct drm_bridge *bridge)