staging: unisys: visornic: remove extraneous error check
authorDavid Binder <david.binder@unisys.com>
Sat, 14 May 2016 03:17:15 +0000 (23:17 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 8 Jun 2016 05:58:16 +0000 (22:58 -0700)
Removes an extraneous error check in devdata_initialize(), and updates the
function comment accordingly.

Signed-off-by: David Binder <david.binder@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/visornic/visornic_main.c

index af81d31..4e3e67c 100644 (file)
@@ -1342,13 +1342,11 @@ visornic_rx(struct uiscmdrsp *cmdrsp)
  *
  *     Setup initial values for the visornic based on channel and default
  *     values.
- *     Returns a pointer to the devdata if successful, else NULL
+ *     Returns a pointer to the devdata structure
  */
 static struct visornic_devdata *
 devdata_initialize(struct visornic_devdata *devdata, struct visor_device *dev)
 {
-       if (!devdata)
-               return NULL;
        devdata->dev = dev;
        devdata->incarnation_id = get_jiffies_64();
        return devdata;