i2c: designware: Sort timing parameter ACPI method calls by the speed
authorJarkko Nikula <jarkko.nikula@linux.intel.com>
Wed, 20 Apr 2022 12:58:02 +0000 (15:58 +0300)
committerWolfram Sang <wsa@kernel.org>
Sat, 14 May 2022 13:43:54 +0000 (15:43 +0200)
It's more logical to read these get timing parameters ACPI method calls
sorted by speed categories in increasing order: Standard-mode,
Fast-mode, Fast-mode Plus and High-speed mode.

Originally these were in order after commit a92ec1746f10
("i2c: designware: get fast plus and high speed *CNT configuration") but
got mixed up over the years.

Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-designware-common.c

index 9f85743..e7d316b 100644 (file)
@@ -266,9 +266,9 @@ int i2c_dw_acpi_configure(struct device *device)
         * selected speed modes.
         */
        i2c_dw_acpi_params(device, "SSCN", &dev->ss_hcnt, &dev->ss_lcnt, &ss_ht);
+       i2c_dw_acpi_params(device, "FMCN", &dev->fs_hcnt, &dev->fs_lcnt, &fs_ht);
        i2c_dw_acpi_params(device, "FPCN", &dev->fp_hcnt, &dev->fp_lcnt, &fp_ht);
        i2c_dw_acpi_params(device, "HSCN", &dev->hs_hcnt, &dev->hs_lcnt, &hs_ht);
-       i2c_dw_acpi_params(device, "FMCN", &dev->fs_hcnt, &dev->fs_lcnt, &fs_ht);
 
        switch (t->bus_freq_hz) {
        case I2C_MAX_STANDARD_MODE_FREQ: