Check buffer size before checking buffer data

If the expected size is bigger than the actual buffer size, it would
memcmp random memory which could lead to crashes instead of proper error
reporting.

diff --git a/libs/gst/check/gstcheck.c b/libs/gst/check/gstcheck.c
index a6e82bc..4f784c8 100644 (file)
--- a/libs/gst/check/gstcheck.c
+++ b/libs/gst/check/gstcheck.c
@@ -801,6 +801,10 @@ gst_check_buffer_data (GstBuffer * buffer, gconstpointer data, gsize size)
   fail_unless (gst_buffer_map (buffer, &info, GST_MAP_READ));
   GST_MEMDUMP ("Converted data", info.data, info.size);
   GST_MEMDUMP ("Expected data", data, size);
+  if (info.size != size) {
+    fail ("buffer sizes not equal: expected %" G_GSIZE_FORMAT " got %"
+        G_GSIZE_FORMAT, size, info.size);
+  }
   if (memcmp (info.data, data, size) != 0) {
     g_print ("\nConverted data:\n");
     gst_util_dump_mem (info.data, info.size);